[PR #668] [MERGED] Fix for 664, open for comment. #1248

New Issue

claunia · 2026-01-29T16:58:54Z

claunia commented

2026-01-29 16:58:54 +00:00

📋 Pull Request Information

Original PR: https://github.com/ElectronNET/Electron.NET/pull/668
Author: @danatcofo
Created: 2/23/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @GregorBiswanger

Base: master ← Head: bug/644

📝 Commits (2)

ab694e2 Change IsReady logic to also wait for connection to be open. This is to prevent actions occurring before the app can act upon them.
468c8ba #644 Check for null before taking actions. Also localize references to window on window creation

📊 Changes

5 files changed (+700 additions, -347 deletions)

View changed files

📝 ElectronNET.API/LifetimeServiceHost.cs (+7 -2)
📝 ElectronNET.Host/api/browserWindows.js (+373 -154)
📝 ElectronNET.Host/api/browserWindows.js.map (+1 -1)
📝 ElectronNET.Host/api/browserWindows.ts (+316 -186)
📝 ElectronNET.WebApp/Startup.cs (+3 -4)

📄 Description

This is a fix for #664 where the window will sometimes be null on doing a reload.

I am not quite sure it fixes the issue wholesale but it does prevent the javascript error from occurring. More testing is required and this PR is here for evaluation and comment. I do not consider it complete at this time.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ElectronNET/Electron.NET/pull/668 **Author:** [@danatcofo](https://github.com/danatcofo) **Created:** 2/23/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@GregorBiswanger](https://github.com/GregorBiswanger) **Base:** `master` ← **Head:** `bug/644` --- ### 📝 Commits (2) - [`ab694e2`](https://github.com/ElectronNET/Electron.NET/commit/ab694e22fc522f2050c493d9269febcd8bbc7b69) Change IsReady logic to also wait for connection to be open. This is to prevent actions occurring before the app can act upon them. - [`468c8ba`](https://github.com/ElectronNET/Electron.NET/commit/468c8ba2fc44ea5682c3d2d5c47465b1c5d1935b) #644 Check for null before taking actions. Also localize references to window on window creation ### 📊 Changes **5 files changed** (+700 additions, -347 deletions) <details> <summary>View changed files</summary> 📝 `ElectronNET.API/LifetimeServiceHost.cs` (+7 -2) 📝 `ElectronNET.Host/api/browserWindows.js` (+373 -154) 📝 `ElectronNET.Host/api/browserWindows.js.map` (+1 -1) 📝 `ElectronNET.Host/api/browserWindows.ts` (+316 -186) 📝 `ElectronNET.WebApp/Startup.cs` (+3 -4) </details> ### 📄 Description This is a fix for #664 where the window will sometimes be null on doing a reload. I am not quite sure it fixes the issue wholesale but it does prevent the javascript error from occurring. More testing is required and this PR is here for evaluation and comment. I do not consider it complete at this time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:54 +00:00

claunia closed this issue

2026-01-29 16:58:54 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Electron.NET#1248