[PR #1376] [MERGED] [setup.py] Use PEP625-compliant lowercase 'brotli' package name #1982

New Issue

claunia · 2026-01-29T20:56:46Z

claunia commented

2026-01-29 20:56:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/1376
Author: @anthrotype
Created: 11/6/2025
Status: ✅ Merged
Merged: 11/6/2025
Merged by: @copybara-service[bot]

Base: master ← Head: normalize-py-name

📝 Commits (1)

808e2b9 [setup.py] Use PEP625-compliant lowercase 'brotli' package name

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 setup.py (+1 -1)

📄 Description

PyPI now requires that wheel filenames and metadata use normalized package names following PEP 625. Modern build tooling automatically normalize this, however this does not happen for old python versions (e.g. 2.7, 3.6, 3.7) which makes their upload fail. I had to apply the same patch to the v1.2.0 release be able to upload all the python wheels to PyPI, see:

https://github.com/google/brotli/issues/1327#issuecomment-3491479583

ca4fed169b

It makes more sense to have this in here and get rid of the patch, regardless of when we drop support for those EOL pythons.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/1376 **Author:** [@anthrotype](https://github.com/anthrotype) **Created:** 11/6/2025 **Status:** ✅ Merged **Merged:** 11/6/2025 **Merged by:** [@copybara-service[bot]](https://github.com/apps/copybara-service) **Base:** `master` ← **Head:** `normalize-py-name` --- ### 📝 Commits (1) - [`808e2b9`](https://github.com/google/brotli/commit/808e2b99e6267ce60ed8b2c31a2f16bc587815eb) [setup.py] Use PEP625-compliant lowercase 'brotli' package name ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+1 -1) </details> ### 📄 Description PyPI now requires that wheel filenames and metadata use normalized package names following PEP 625. Modern build tooling automatically normalize this, however this does not happen for old python versions (e.g. 2.7, 3.6, 3.7) which makes their upload fail. I had to apply the same patch to the v1.2.0 release be able to upload all the python wheels to PyPI, see: https://github.com/google/brotli/issues/1327#issuecomment-3491479583 https://github.com/google/brotli-wheels/commit/ca4fed169bb72d09d0263feb34853247da9f4a45 It makes more sense to have this in here and get rid of the patch, regardless of when we drop support for those EOL pythons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:56:46 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#1982