[PR #748] [CLOSED] Fix config_setting for msvc #1376

New Issue

claunia · 2026-01-29T20:53:47Z

claunia commented

2026-01-29 20:53:47 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/748
Author: @meteorcloudy
Created: 4/9/2019
Status: ❌ Closed

Base: master ← Head: fix_msvc_config_setting

📝 Commits (1)

7388ebb Fix config_setting for msvc

📊 Changes

2 files changed (+24 additions, -5 deletions)

View changed files

📝 BUILD (+3 -5)
➕ compiler_config_setting.bzl (+21 -0)

📄 Description

Route "compiler" value of config_setting through @bazel_tools/tools/cpp:compiler.
This is necessary for modern Bazel version.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/748 **Author:** [@meteorcloudy](https://github.com/meteorcloudy) **Created:** 4/9/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_msvc_config_setting` --- ### 📝 Commits (1) - [`7388ebb`](https://github.com/google/brotli/commit/7388ebb113f0e1dbf4ab0f2daddf036abf29b8e6) Fix config_setting for msvc ### 📊 Changes **2 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `BUILD` (+3 -5) ➕ `compiler_config_setting.bzl` (+21 -0) </details> ### 📄 Description Route "compiler" value of config_setting through @bazel_tools/tools/cpp:compiler. This is necessary for modern Bazel version. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:53:47 +00:00

claunia referenced this issue

2026-01-29 20:56:46 +00:00

[PR #1376] [MERGED] [setup.py] Use PEP625-compliant lowercase 'brotli' package name #1982

claunia referenced this issue

2026-01-29 20:56:47 +00:00

[PR #1376] [setup.py] Use PEP625-compliant lowercase 'brotli' package name #1986

Sign in to join this conversation.