[PR #1376] [setup.py] Use PEP625-compliant lowercase 'brotli' package name #1986

Closed
opened 2026-01-29 20:56:47 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/google/brotli/pull/1376

State: closed
Merged: Yes


PyPI now requires that wheel filenames and metadata use normalized package names following PEP 625. Modern build tooling automatically normalize this, however this does not happen for old python versions (e.g. 2.7, 3.6, 3.7) which makes their upload fail. I had to apply the same patch to the v1.2.0 release be able to upload all the python wheels to PyPI, see:

https://github.com/google/brotli/issues/1327#issuecomment-3491479583

ca4fed169b

It makes more sense to have this in here and get rid of the patch, regardless of when we drop support for those EOL pythons.

**Original Pull Request:** https://github.com/google/brotli/pull/1376 **State:** closed **Merged:** Yes --- PyPI now requires that wheel filenames and metadata use normalized package names following PEP 625. Modern build tooling automatically normalize this, however this does not happen for old python versions (e.g. 2.7, 3.6, 3.7) which makes their upload fail. I had to apply the same patch to the v1.2.0 release be able to upload all the python wheels to PyPI, see: https://github.com/google/brotli/issues/1327#issuecomment-3491479583 https://github.com/google/brotli-wheels/commit/ca4fed169bb72d09d0263feb34853247da9f4a45 It makes more sense to have this in here and get rid of the patch, regardless of when we drop support for those EOL pythons.
claunia added the pull-request label 2026-01-29 20:56:47 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#1986