Use shared libraries for linking the main executable #278

New Issue

claunia · 2026-01-29T20:41:18Z

claunia commented

2026-01-29 20:41:18 +00:00

Originally created by @moubctez on GitHub (Apr 19, 2019).

Currenly, the main executable is quite large, because it is being linked against static libraries. Please, consider linking it against the shared libraries. The following patch does the shared linking:

--- CMakeLists.txt.orig
+++ CMakeLists.txt
@@ -183,7 +183,7 @@ endif()
 
 # Build the brotli executable
 add_executable(brotli ${BROTLI_CLI_C})
-target_link_libraries(brotli ${BROTLI_LIBRARIES_STATIC})
+target_link_libraries(brotli ${BROTLI_LIBRARIES})
 
 # Installation
 if(NOT BROTLI_BUNDLED_MODE)

Originally created by @moubctez on GitHub (Apr 19, 2019). Currenly, the main executable is quite large, because it is being linked against static libraries. Please, consider linking it against the shared libraries. The following patch does the shared linking: ``` --- CMakeLists.txt.orig +++ CMakeLists.txt @@ -183,7 +183,7 @@ endif() # Build the brotli executable add_executable(brotli ${BROTLI_CLI_C}) -target_link_libraries(brotli ${BROTLI_LIBRARIES_STATIC}) +target_link_libraries(brotli ${BROTLI_LIBRARIES}) # Installation if(NOT BROTLI_BUNDLED_MODE) ```

claunia closed this issue

2026-01-29 20:41:18 +00:00

claunia commented

2026-01-29 20:41:19 +00:00

@eustas commented on GitHub (Jul 17, 2019):

That is done intentionally, so that brotli executable compiled in one container would be executed in other container without any deps.

Do you have some specific scenario, where shared-linked brotli CLI would be useful?
In that case it would be better to add a configuration option...

@eustas commented on GitHub (Jul 17, 2019): That is done intentionally, so that brotli executable compiled in one container would be executed in other container without any deps. Do you have some specific scenario, where shared-linked brotli CLI would be useful? In that case it would be better to add a configuration option...

claunia commented

2026-01-29 20:41:19 +00:00

@lazka commented on GitHub (Sep 5, 2023):

Looks like this was fixed in 641bec0e30, the main binary now links against the shared lib by default starting with v1.1.0

@lazka commented on GitHub (Sep 5, 2023): Looks like this was fixed in 641bec0e30bea648b3, the main binary now links against the shared lib by default starting with v1.1.0

claunia referenced this issue

2026-01-29 20:51:24 +00:00

[PR #278] [MERGED] don't pass `-std=c++0x` option to gcc in setup.py #878

claunia referenced this issue

2026-01-29 20:51:25 +00:00

[PR #278] don't pass `-std=c++0x` option to gcc in setup.py #883

claunia referenced this issue

2026-01-29 20:51:29 +00:00

[PR #291] [MERGED] Remove -std=c++11 from shared.mk #891

Sign in to join this conversation.