starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-07-08 17:56:58 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #278] [MERGED] don't pass -std=c++0x option to gcc in setup.py #878

New Issue
Open
opened 2026-01-29 20:51:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:51:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/278
Author: @anthrotype
Created: 12/8/2015
Status: ✅ Merged
Merged: 12/9/2015
Merged by: @szabadka

Base: master ← Head: python-disable-c++0x

📝 Commits (2)

  • 8b2ca8e setup.py: don't enable c++0x for gcc
  • 912b0ac brotlimodule.cc: fix error with clang ('expected a class or namespace')

📊 Changes

2 files changed (+8 additions, -12 deletions)

View changed files

📝 python/brotlimodule.cc (+6 -6)
📝 setup.py (+2 -6)

📄 Description

Now that Brotli can be built with older compilers that don't support C++11, I think it's fine to turn that off in the setup.py script which compiles the Python extension module.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/278 **Author:** [@anthrotype](https://github.com/anthrotype) **Created:** 12/8/2015 **Status:** ✅ Merged **Merged:** 12/9/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `python-disable-c++0x` --- ### 📝 Commits (2) - [`8b2ca8e`](https://github.com/google/brotli/commit/8b2ca8efd96d811616969f7324d5d614cceae50f) setup.py: don't enable c++0x for gcc - [`912b0ac`](https://github.com/google/brotli/commit/912b0ac2c40e9eef962d918ddf4a3c0662d41a75) brotlimodule.cc: fix error with clang ('expected a class or namespace') ### 📊 Changes **2 files changed** (+8 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `python/brotlimodule.cc` (+6 -6) 📝 `setup.py` (+2 -6) </details> ### 📄 Description Now that Brotli can be built with older compilers that don't support C++11, I think it's fine to turn that off in the `setup.py` script which compiles the Python extension module. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:51:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#878
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?