Indentical header names, different contents #35

Closed
opened 2026-01-29 20:29:31 +00:00 by claunia · 1 comment
Owner

Originally created by @bagder on GitHub (Sep 27, 2015).

Hey, issue #151 mentions how dictionary.h exists in two versions in enc/ and dec/ while they perhaps should be identical.

What about other headers like streams.h that exist in both directories but are very different?

I've been putting together a little build setup that creates a libbrotli so that we can write test applications easier against the brotli code and when we install the public headers I would like to put them into the same directory (under brotli/) mostly since using more than one slash for a public header for a library is quite unusual for C and C++ programs.

As I suspect you too might want to do this at some point, or just help my project function, I figure it could be an idea to consider having different headers use different file names even when they are in a different directory in your source tree.

Originally created by @bagder on GitHub (Sep 27, 2015). Hey, issue #151 mentions how dictionary.h exists in two versions in enc/ and dec/ while they perhaps should be identical. What about other headers like streams.h that exist in both directories but are very different? I've been putting together a little build setup that creates a [libbrotli](https://github.com/bagder/libbrotli) so that we can write test applications easier against the brotli code and when we install the public headers I would like to put them into the same directory (under brotli/) mostly since using more than one slash for a public header for a library is quite unusual for C and C++ programs. As I suspect you too might want to do this at some point, or just help my project function, I figure it could be an idea to consider having different headers use different file names even when they are in a different directory in your source tree.
Author
Owner

@bagder commented on GitHub (Sep 29, 2015):

We decided having them as two libs might be the best way forward, so having the files in separate directories then became less of an issue...

@bagder commented on GitHub (Sep 29, 2015): We decided having them as two libs might be the best way forward, so having the files in separate directories then became less of an issue...
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#35