starred/brotli
1
0
Fork 0
mirror of https://github.com/google/brotli.git synced 2026-09-22 06:35:52 +00:00
Code Issues 1.2k Packages Projects Releases 20 Wiki Activity

[PR #35] [MERGED] Makefile fixes and cleanups #615

New Issue
Open
opened 2026-01-29 20:46:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 20:46:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/35
Author: @mitya57
Created: 3/13/2015
Status: ✅ Merged
Merged: 4/23/2015
Merged by: @szabadka

Base: master ← Head: master

📝 Commits (1)

  • 5da7e37 Makefile fixes and cleanups

📊 Changes

4 files changed (+15 additions, -16 deletions)

View changed files

📝 dec/Makefile (+1 -1)
📝 shared.mk (+7 -8)
📝 tests/Makefile (+2 -2)
📝 tools/Makefile (+5 -5)

📄 Description

  • Distinguish between CC/CFLAGS, CPP/CPPFLAGS and CXX/CXXFLAGS.
    Do not store compiler flags in CPPFLAGS, which is for preprocessor.
  • Use COMMON_FLAGS for flags that are for both C and C++.
  • Drop -m64 flag which is wrong on 32-bit systems.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/35 **Author:** [@mitya57](https://github.com/mitya57) **Created:** 3/13/2015 **Status:** ✅ Merged **Merged:** 4/23/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5da7e37`](https://github.com/google/brotli/commit/5da7e37a064724810fcb747f40daf23e3c1d37f4) Makefile fixes and cleanups ### 📊 Changes **4 files changed** (+15 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `dec/Makefile` (+1 -1) 📝 `shared.mk` (+7 -8) 📝 `tests/Makefile` (+2 -2) 📝 `tools/Makefile` (+5 -5) </details> ### 📄 Description - Distinguish between CC/CFLAGS, CPP/CPPFLAGS and CXX/CXXFLAGS. Do not store compiler flags in CPPFLAGS, which is for preprocessor. - Use COMMON_FLAGS for flags that are for both C and C++. - Drop -m64 flag which is wrong on 32-bit systems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:46:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
feature
help wanted
pull-request
Mirrored from GitHub Pull Request
 release-v1.1
release-v1.1.1
release-v1.2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?