[PR #242] [MERGED] Added note about invalid block type value in block switch commands #839

New Issue

claunia · 2026-01-29T20:51:10Z

claunia commented

2026-01-29 20:51:10 +00:00

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/242
Author: @ende76
Created: 10/26/2015
Status: ✅ Merged
Merged: 10/27/2015
Merged by: @szabadka

Base: master ← Head: spec_suggest_block_switch

📝 Commits (2)

e544a18 Added note about invalid block type value
1128653 Removed previous change, fixed typo NBLTYPES -> NBLTYPESL #242

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 docs/draft-alakuijala-brotli-07.nroff (+1 -1)
📝 docs/draft-alakuijala-brotli-07.txt (+1 -1)

📄 Description

Added an explicit note to reject a stream as invalid, if a block type in a block switch command is not within its 0..NBLTYPEx-1 range.
I believe it is of value to mention rejection conditions explicitly in the spec, and with a consistent phrase ("the stream should be rejected as invalid"), to make it easy for implementers to find these conditions through a simple text search.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/242 **Author:** [@ende76](https://github.com/ende76) **Created:** 10/26/2015 **Status:** ✅ Merged **Merged:** 10/27/2015 **Merged by:** [@szabadka](https://github.com/szabadka) **Base:** `master` ← **Head:** `spec_suggest_block_switch` --- ### 📝 Commits (2) - [`e544a18`](https://github.com/google/brotli/commit/e544a185f937077894101ba491f49a93f851bc25) Added note about invalid block type value - [`1128653`](https://github.com/google/brotli/commit/11286539a59bb71b6a62e3c8f1b0884d8554a97c) Removed previous change, fixed typo NBLTYPES -> NBLTYPESL #242 ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/draft-alakuijala-brotli-07.nroff` (+1 -1) 📝 `docs/draft-alakuijala-brotli-07.txt` (+1 -1) </details> ### 📄 Description Added an explicit note to reject a stream as invalid, if a block type in a block switch command is not within its 0..NBLTYPEx-1 range. I believe it is of value to mention rejection conditions explicitly in the spec, and with a consistent phrase ("the stream should be rejected as invalid"), to make it easy for implementers to find these conditions through a simple text search. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 20:51:10 +00:00

claunia referenced this issue

2026-01-29 20:54:05 +00:00

[PR #839] [MERGED] Fix clang-10 compilation issue #1436

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#839