[PR #246] [CLOSED] Suggested RFC changes #841

Open
opened 2026-01-29 20:51:10 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/google/brotli/pull/246
Author: @dsnet
Created: 10/29/2015
Status: Closed

Base: masterHead: master


📝 Commits (10+)

  • 6db33de Merge pull request #1 from google/master
  • 6ad0428 Minor formatting changes
  • 317ea91 Fix ambiguity about whether final bit padding must be zero
  • 1a5c031 Make pseudo-code more code-like
  • 466f356 Clarify simple and complex prefix codes
  • 1a4f884 Define the maximum number of bytes transforms may add to a word
  • 805ff4f Minor formatting changes
  • 04ba9ac Minor formatting of Section 9.2. and Section 9.3.
  • fcd05db Clarify Section 4.
  • 2459bb7 Use consistent bit convention in Section 5.

📊 Changes

1 file changed (+248 additions, -190 deletions)

View changed files

📝 docs/draft-alakuijala-brotli-07.nroff (+248 -190)

📄 Description

I recommend reviewing each commit individually. The "large" commits that touch many lines are actually fairly mechanical changes that do not change the semantic meaning of the text at all. I included rationale for every change in the description of each commit.

Keeping track of what has been merged (or abandoned):

  • (6ad0428) Minor formatting changes
  • (317ea91) Fix ambiguity about whether final bit padding must be zero
  • (1a5c031) Make pseudo-code more code-like
  • (466f356) Clarify simple and complex prefix codes
  • (1a4f884) Define the maximum number of bytes transforms may add to a word
  • (805ff4f) Minor formatting changes
  • (04ba9ac) Minor formatting of Section 9.2. and Section 9.3.
  • (fcd05db) Clarify Section 4.
  • (2459bb7) Use consistent bit convention in Section 5.
  • (f9f173c) Clarify section 7.1.
  • (4d375a2) Clarify Section 7.3
  • (238d459) Clarify Section 8.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/google/brotli/pull/246 **Author:** [@dsnet](https://github.com/dsnet) **Created:** 10/29/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`6db33de`](https://github.com/google/brotli/commit/6db33debac15f95f89dc9d3c0d748daa0a3f0b4e) Merge pull request #1 from google/master - [`6ad0428`](https://github.com/google/brotli/commit/6ad042827b6ae6a9410ea8eada09471138908538) Minor formatting changes - [`317ea91`](https://github.com/google/brotli/commit/317ea914ee453a32ba098b9c3698937edc66ba28) Fix ambiguity about whether final bit padding must be zero - [`1a5c031`](https://github.com/google/brotli/commit/1a5c031cc4356974e74e99f0b8e85abd419f30cb) Make pseudo-code more code-like - [`466f356`](https://github.com/google/brotli/commit/466f356a5c2b15d479b11e9f73548158a81f28e9) Clarify simple and complex prefix codes - [`1a4f884`](https://github.com/google/brotli/commit/1a4f884b2398bfee59df01579dd280751aed4ccb) Define the maximum number of bytes transforms may add to a word - [`805ff4f`](https://github.com/google/brotli/commit/805ff4ff777deb2b31b4f111b57519eec4534f3c) Minor formatting changes - [`04ba9ac`](https://github.com/google/brotli/commit/04ba9ac6e2c2d3916b85410b6ad9bd66d400bb67) Minor formatting of Section 9.2. and Section 9.3. - [`fcd05db`](https://github.com/google/brotli/commit/fcd05db024025fe7b9aa40b15dbb69f9108fa34b) Clarify Section 4. - [`2459bb7`](https://github.com/google/brotli/commit/2459bb743cf67461549fa03937c6fc9622ff9590) Use consistent bit convention in Section 5. ### 📊 Changes **1 file changed** (+248 additions, -190 deletions) <details> <summary>View changed files</summary> 📝 `docs/draft-alakuijala-brotli-07.nroff` (+248 -190) </details> ### 📄 Description I recommend reviewing each commit individually. The "large" commits that touch many lines are actually fairly mechanical changes that do not change the semantic meaning of the text at all. I included rationale for every change in the description of each commit. Keeping track of what has been merged (or abandoned): - ~~(6ad0428) Minor formatting changes~~ - ~~(317ea91) Fix ambiguity about whether final bit padding must be zero~~ - (1a5c031) Make pseudo-code more code-like - ~~(466f356) Clarify simple and complex prefix codes~~ - ~~(1a4f884) Define the maximum number of bytes transforms may add to a word~~ - (805ff4f) Minor formatting changes - ~~(04ba9ac) Minor formatting of Section 9.2. and Section 9.3.~~ - ~~(fcd05db) Clarify Section 4.~~ - ~~(2459bb7) Use consistent bit convention in Section 5.~~ - ~~(f9f173c) Clarify section 7.1.~~ - ~~(4d375a2) Clarify Section 7.3~~ - ~~(238d459) Clarify Section 8.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 20:51:10 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#841