Potential "Control flow issues" detected by Coverity #246

New Issue

claunia · 2026-01-29T20:40:40Z

claunia commented

2026-01-29 20:40:40 +00:00

Originally created by @sylvestre on GitHub (Jul 9, 2018).

Updating to brotli 1.0.5 in Firefox, coverity discovered two new issues (CID 1437666 & 1437667)

For
https://github.com/google/brotli/blob/master/c/enc/hash_rolling_inc.h#L131
Coverity says:

dead_error_condition: The condition (position & 0UL) != 0UL cannot be true.

And for
https://github.com/google/brotli/blob/master/c/enc/hash_rolling_inc.h#L164

dead_error_condition: The condition (cur_ix & 0UL) != 0UL cannot be true.

As they do not seem to be false positive, I prefer to report them!

Originally created by @sylvestre on GitHub (Jul 9, 2018). Updating to [brotli 1.0.5 in Firefox](https://bugzilla.mozilla.org/show_bug.cgi?id=1474122), coverity discovered two new issues (CID 1437666 & 1437667) For https://github.com/google/brotli/blob/master/c/enc/hash_rolling_inc.h#L131 Coverity says: > dead_error_condition: The condition (position & 0UL) != 0UL cannot be true. And for https://github.com/google/brotli/blob/master/c/enc/hash_rolling_inc.h#L164 > dead_error_condition: The condition (cur_ix & 0UL) != 0UL cannot be true. As they do not seem to be false positive, I prefer to report them!

claunia referenced this issue

2026-01-29 20:51:10 +00:00

[PR #246] [CLOSED] Suggested RFC changes #841

claunia referenced this issue

2026-01-29 20:51:11 +00:00

[PR #246] Suggested RFC changes #846

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/brotli#246