[PR #246] Suggested RFC changes #846

Open
opened 2026-01-29 20:51:11 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/google/brotli/pull/246

State: closed
Merged: No


I recommend reviewing each commit individually. The "large" commits that touch many lines are actually fairly mechanical changes that do not change the semantic meaning of the text at all. I included rationale for every change in the description of each commit.

Keeping track of what has been merged (or abandoned):

  • (6ad0428) Minor formatting changes
  • (317ea91) Fix ambiguity about whether final bit padding must be zero
  • (1a5c031) Make pseudo-code more code-like
  • (466f356) Clarify simple and complex prefix codes
  • (1a4f884) Define the maximum number of bytes transforms may add to a word
  • (805ff4f) Minor formatting changes
  • (04ba9ac) Minor formatting of Section 9.2. and Section 9.3.
  • (fcd05db) Clarify Section 4.
  • (2459bb7) Use consistent bit convention in Section 5.
  • (f9f173c) Clarify section 7.1.
  • (4d375a2) Clarify Section 7.3
  • (238d459) Clarify Section 8.
**Original Pull Request:** https://github.com/google/brotli/pull/246 **State:** closed **Merged:** No --- I recommend reviewing each commit individually. The "large" commits that touch many lines are actually fairly mechanical changes that do not change the semantic meaning of the text at all. I included rationale for every change in the description of each commit. Keeping track of what has been merged (or abandoned): - ~~(6ad0428) Minor formatting changes~~ - ~~(317ea91) Fix ambiguity about whether final bit padding must be zero~~ - (1a5c031) Make pseudo-code more code-like - ~~(466f356) Clarify simple and complex prefix codes~~ - ~~(1a4f884) Define the maximum number of bytes transforms may add to a word~~ - (805ff4f) Minor formatting changes - ~~(04ba9ac) Minor formatting of Section 9.2. and Section 9.3.~~ - ~~(fcd05db) Clarify Section 4.~~ - ~~(2459bb7) Use consistent bit convention in Section 5.~~ - ~~(f9f173c) Clarify section 7.1.~~ - ~~(4d375a2) Clarify Section 7.3~~ - ~~(238d459) Clarify Section 8.~~
claunia added the pull-request label 2026-01-29 20:51:11 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/brotli#846