starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-07-08 18:06:30 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

Fix: Add missing SCTE-20 marker bit syntax check (resolves TODO)

Browse Source
This commit is contained in:
Pranav Sharma
2026-02-20 10:03:50 +00:00
parent 6f7ce27b3d
commit 381489f82c
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib_ccx/es_userdata.c
View File

@@ -161,11 +161,17 @@ int user_data(struct encoder_ctx *enc_ctx, struct lib_cc_decode *dec_ctx, struct
skip_bits(ustream, 5); // line_offset - unused
cc_data1 = (unsigned int)read_bits(ustream, 8);
cc_data2 = (unsigned int)read_bits(ustream, 8);
read_bits(ustream, 1); // TODO: Add syntax check */
unsigned char marker_bit = read_bits(ustream, 1);
if (ustream->bitsleft < 0)
fatal(CCX_COMMON_EXIT_BUG_BUG, "In user_data: ustream->bitsleft < 0. Cannot continue.");
if (marker_bit == 0)
{
dbg_print(CCX_DMT_VERBOSE, "user_data: SCTE-20 syntax error - marker bit is 0\n");
continue; // Skip processing this corrupted block
}
// Field_number is either
// 0 .. forbidden
// 1 .. field 1 (odd)

6
src/rust/src/es/userdata.rs
View File

@@ -180,10 +180,14 @@ pub unsafe fn user_data(
ustream.skip_bits(5)?; // line_offset - unused
let cc_data1 = ustream.read_bits(8)? as u32;
let cc_data2 = ustream.read_bits(8)? as u32;
ustream.read_bits(1)?; // TODO: Add syntax check */
let marker_bit = ustream.read_bits(1)?;
if ustream.bits_left < 0 {
fatal!(cause = ExitCause::Bug; "In user_data: ustream->bitsleft < 0. Cannot continue.");
}
if marker_bit == 0 {
debug!(msg_type = DebugMessageFlag::VERBOSE; "user_data: SCTE-20 syntax error - marker bit is 0");
continue; // Skip processing this corrupted block
}
// Field_number is either
// 0 .. forbidden