starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-09-22 23:04:57 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

Fix potential out-of-bounds access in write_stringz_as_srt_to_output (#2128)

Browse Source 
* Fix loop condition for reading unescaped string

* Fix condition to check for newline escape sequence

* Fix formatting
This commit is contained in:
rhythmcache
2026-03-07 13:14:40 +05:30
committed by GitHub
parent f377be9578
commit e4bcade799
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib_ccx/ccx_encoders_srt.c
View File

@@ -47,7 +47,7 @@ static int write_stringz_as_srt_to_output(char *string, struct encoder_ctx *cont
// Scan for \n in the string and replace it with a 0
while (pos_r < len)
{
if (string[pos_r] == '\\' && string[pos_r + 1] == 'n')
if (pos_r < len - 1 && string[pos_r] == '\\' && string[pos_r + 1] == 'n')
{
unescaped[pos_w] = 0;
pos_r += 2;
@@ -62,7 +62,7 @@ static int write_stringz_as_srt_to_output(char *string, struct encoder_ctx *cont
unescaped[pos_w] = 0;
// Now read the unescaped string (now several string'z and write them)
unsigned char *begin = unescaped;
while (begin < unescaped + len)
while (begin < unescaped + pos_w)
{
unsigned int u = encode_line(context, el, begin);
if (context->encoding != CCX_ENC_UNICODE)