[PR #165] [MERGED] Possible MP4 detection fix #1052

New Issue

claunia · 2026-01-29T16:58:41Z

claunia commented

2026-01-29 16:58:41 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/165
Author: @canihavesomecoffee
Created: 5/15/2015
Status: ✅ Merged
Merged: 5/15/2015
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (1)

1a1aa74 Possible MP4 detection fix

📊 Changes

2 files changed (+96 additions, -42 deletions)

View changed files

📝 src/lib_ccx/lib_ccx.h (+1 -0)
📝 src/lib_ccx/stream_functions.c (+95 -42)

📄 Description

Expanded detection for mp4. This fix does not affect any other files (as opposed to the initial "fix").

New detection code requires a couple of valid mp4 boxes after each other instead of just a single string reference. It uses the length parameter of the supposed mp4 boxes to skip the contents of the supposed boxes (as would be the case in mp4).

Checked with test suite
Discussed with Carlos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/165 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 5/15/2015 **Status:** ✅ Merged **Merged:** 5/15/2015 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1a1aa74`](https://github.com/CCExtractor/ccextractor/commit/1a1aa746d59dfb5a0d81c8fd28285f497cca018f) Possible MP4 detection fix ### 📊 Changes **2 files changed** (+96 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/lib_ccx.h` (+1 -0) 📝 `src/lib_ccx/stream_functions.c` (+95 -42) </details> ### 📄 Description Expanded detection for mp4. This fix does not affect any other files (as opposed to the initial "fix"). New detection code requires a couple of valid mp4 boxes after each other instead of just a single string reference. It uses the length parameter of the supposed mp4 boxes to skip the contents of the supposed boxes (as would be the case in mp4). - [x] Checked with test suite - [x] Discussed with Carlos --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 16:58:41 +00:00

claunia referenced this issue

2026-01-29 17:18:53 +00:00

[PR #1052] [MERGED] **[FIX]** Fix typos; **[IMPROVEMENT]** Update .gitignore for Visual Studio databases #1855

claunia referenced this issue

2026-01-29 17:18:54 +00:00

[PR #1052] **[FIX]** Fix typos; **[IMPROVEMENT]** Update .gitignore for Visual Studio databases #1857

Sign in to join this conversation.