[PR #334] [CLOSED] Fixing issues with ISDB #1175

New Issue

claunia · 2026-01-29T17:00:02Z

claunia commented

2026-01-29 17:00:02 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/334
Author: @Abhinav95
Created: 3/17/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

02b93fa ISDB - Fixing end timestamp and ignoring teletext page value NA in -ucla
78585c8 ISDB timestamps now incrementing by setting current timestamp to the FTS

📊 Changes

6 files changed (+18 additions, -8 deletions)

View changed files

📝 src/lib_ccx/ccx_common_option.c (+1 -0)
📝 src/lib_ccx/ccx_common_option.h (+2 -0)
📝 src/lib_ccx/ccx_decoders_isdb.c (+1 -0)
📝 src/lib_ccx/ccx_encoders_common.c (+9 -7)
📝 src/lib_ccx/ccx_encoders_common.h (+2 -0)
📝 src/lib_ccx/params.c (+3 -1)

📄 Description

#284

The current fix I have used is setting the current timestamp of the detected subtitle line to the FTS at that point. This makes the timestamps increment according to the time the subtitle was found in the file (which is correct), but the end time is considered as the start time of the next subtitle line (which is not always correct). In any case, it is a much more accurate representation and way better than the timestamps not incrementing at all.

Also, this pull request takes care of removing the "NA" in the third column when using -UCLA.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/334 **Author:** [@Abhinav95](https://github.com/Abhinav95) **Created:** 3/17/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`02b93fa`](https://github.com/CCExtractor/ccextractor/commit/02b93fa73f579881cd6dd719af486557ab764309) ISDB - Fixing end timestamp and ignoring teletext page value NA in -ucla - [`78585c8`](https://github.com/CCExtractor/ccextractor/commit/78585c84b4cfd549d3f6e9fc0825216fd11b6eab) ISDB timestamps now incrementing by setting current timestamp to the FTS ### 📊 Changes **6 files changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_option.c` (+1 -0) 📝 `src/lib_ccx/ccx_common_option.h` (+2 -0) 📝 `src/lib_ccx/ccx_decoders_isdb.c` (+1 -0) 📝 `src/lib_ccx/ccx_encoders_common.c` (+9 -7) 📝 `src/lib_ccx/ccx_encoders_common.h` (+2 -0) 📝 `src/lib_ccx/params.c` (+3 -1) </details> ### 📄 Description #284 The current fix I have used is setting the current timestamp of the detected subtitle line to the FTS at that point. This makes the timestamps increment according to the time the subtitle was found in the file (which is correct), but the end time is considered as the start time of the next subtitle line (which is not always correct). In any case, it is a much more accurate representation and way better than the timestamps not incrementing at all. Also, this pull request takes care of removing the "NA" in the third column when using -UCLA. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:00:02 +00:00

claunia referenced this issue

2026-01-29 17:19:28 +00:00

[PR #1175] [CLOSED] [IMPROVEMENT] Remove useless if statement #1963

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1175