[PR #1175] [CLOSED] [IMPROVEMENT] Remove useless if statement #1963

New Issue

claunia · 2026-01-29T17:19:28Z

claunia commented

2026-01-29 17:19:28 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1175
Author: @NilsIrl
Created: 1/10/2020
Status: ❌ Closed

Base: master ← Head: random

📝 Commits (2)

222f60c Remove useless if statement
f992bc3 Formatting

📊 Changes

3 files changed (+6 additions, -8 deletions)

View changed files

📝 src/ccextractor.c (+2 -4)
📝 src/lib_ccx/es_functions.c (+2 -2)
📝 src/lib_ccx/sequencing.c (+2 -2)

📄 Description

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have used CCExtractor just a couple of times.

Increases readability (IMO).

I was told by canihavesomecoffee that code improvement PRs are always welcome so I opened this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1175 **Author:** [@NilsIrl](https://github.com/NilsIrl) **Created:** 1/10/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `random` --- ### 📝 Commits (2) - [`222f60c`](https://github.com/CCExtractor/ccextractor/commit/222f60c6d56c899b49cb470b648c6161b0325feb) Remove useless if statement - [`f992bc3`](https://github.com/CCExtractor/ccextractor/commit/f992bc3f52b946e4b53cc4789a73ed9f0cef8539) Formatting ### 📊 Changes **3 files changed** (+6 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/ccextractor.c` (+2 -4) 📝 `src/lib_ccx/es_functions.c` (+2 -2) 📝 `src/lib_ccx/sequencing.c` (+2 -2) </details> ### 📄 Description - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Increases readability (IMO). I was told by canihavesomecoffee that code improvement PRs are always welcome so I opened this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:19:28 +00:00

claunia closed this issue

2026-01-29 17:19:29 +00:00

claunia referenced this issue

2026-01-29 17:23:47 +00:00

[PR #1964] [CLOSED] fix TS/ES: Integer overflow, stack overflow, heap over-read #2760

claunia referenced this issue

2026-01-29 17:23:48 +00:00

[PR #1964] fix TS/ES: Integer overflow, stack overflow, heap over-read #2764

Sign in to join this conversation.