[PR #590] [MERGED] SMPTE-TT : Added support for font color. #1431

New Issue

claunia · 2026-01-29T17:16:23Z

claunia commented

2026-01-29 17:16:23 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/590
Author: @saurabhshri
Created: 12/30/2016
Status: ✅ Merged
Merged: 12/31/2016
Merged by: @cfsmp3

Base: master ← Head: patch-5

📝 Commits (2)

6c1ba95 Proper string termination.
afc8a3d Added support for font color.

📊 Changes

1 file changed (+59 additions, -7 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_smptett.c (+59 -7)

📄 Description

Before :

<p ...>
       <span>Hello <font color="#ff0000">red on yellow</font>!
       <style tts:backgroundColor="#000000FF" tts:fontSize="18px"/></span>
</p>

Now :

<p ...>
       <span>Hello <span>red on yellow<style tts:backgroundColor="#FFFF00FF" tts:color="ff0000" tts:fontSize="18px"/></span>!
       <style tts:backgroundColor="#000000FF" tts:fontSize="18px"/></span>
</p>

Also, fix for the annoying appearance of garbled text at the end of sentence.
I tried my best to explain the implementation using comments. In case of any doubt/ issue, please give feedback. :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/590 **Author:** [@saurabhshri](https://github.com/saurabhshri) **Created:** 12/30/2016 **Status:** ✅ Merged **Merged:** 12/31/2016 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `patch-5` --- ### 📝 Commits (2) - [`6c1ba95`](https://github.com/CCExtractor/ccextractor/commit/6c1ba95f89c3ab2f79472e56bb2f5e22354923e5) Proper string termination. - [`afc8a3d`](https://github.com/CCExtractor/ccextractor/commit/afc8a3d764cb80dccdd9aa373c61971f19c3e7b8) Added support for font color. ### 📊 Changes **1 file changed** (+59 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_smptett.c` (+59 -7) </details> ### 📄 Description **Before :** ``` <p ...> <span>Hello <font color="#ff0000">red on yellow</font>! <style tts:backgroundColor="#000000FF" tts:fontSize="18px"/></span> </p> ``` **Now :** ``` <p ...> <span>Hello <span>red on yellow<style tts:backgroundColor="#FFFF00FF" tts:color="ff0000" tts:fontSize="18px"/></span>! <style tts:backgroundColor="#000000FF" tts:fontSize="18px"/></span> </p> ``` Also, fix for the annoying appearance of garbled text at the end of sentence. I tried my best to explain the implementation using comments. In case of any doubt/ issue, please give feedback. :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:16:23 +00:00

claunia closed this issue

2026-01-29 17:16:24 +00:00

claunia referenced this issue

2026-01-29 17:20:42 +00:00

[PR #1431] [MERGED] [FIX] Fix issue #1421 #2179

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1431