[PR #1431] [MERGED] [FIX] Fix issue #1421

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1431 **Author:** [@nikolabr](https://github.com/nikolabr) **Created:** 4/12/2022 **Status:** ✅ Merged **Merged:** 6/17/2022 **Merged by:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`8c9047e`](https://github.com/CCExtractor/ccextractor/commit/8c9047e268327f5c5bb4e611e214a1778947012e) [Fix] Fix issue #1421 - [`c31ad2d`](https://github.com/CCExtractor/ccextractor/commit/c31ad2db6b48eefb7e80eea58cd207a4337225f1) Fix header offset ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/stream_functions.c` (+4 -0) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [x] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This pull request fixes Issue #1421, by checking if a box of type `moov` also has a valid movie header (mvhd). This might cause problems with files which do not have the header at the start of the box. I could not confirm if such files exist, but all the files I tested with do have the `mvhd` header at the start of the `moov` box. This might require some further testing, as it might cause problems with such MP4 containers which could contain another atom before the `mvhd` header. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:20:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1431
Author: @nikolabr
Created: 4/12/2022
Status: ✅ Merged
Merged: 6/17/2022
Merged by: @canihavesomecoffee

Base: master ← Head: master

📝 Commits (2)

8c9047e [Fix] Fix issue [PR #581] Minor changes in .sln (#1421)
c31ad2d Fix header offset

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src/lib_ccx/stream_functions.c (+4 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This pull request fixes Issue #1421, by checking if a box of type moov also has a valid movie header (mvhd). This might cause problems with files which do not have the header at the start of the box. I could not confirm if such files exist, but all the files I tested with do have the mvhd header at the start of the moov box. This might require some further testing, as it might cause problems with such MP4 containers which could contain another atom before the mvhd header.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:20:42 +00:00

claunia closed this issue

[PR #1431] [MERGED] [FIX] Fix issue #1421 #2179

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description