[PR #640] [MERGED] Subs 708 #1489

Open
opened 2026-01-29 17:16:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/640
Author: @Izaron
Created: 1/12/2017
Status: Merged
Merged: 1/12/2017
Merged by: @cfsmp3

Base: masterHead: subs-708


📝 Commits (4)

  • ebd9fc4 Minor mistake in bitsream fixed
  • ddce582 Musical note should replace 'Delete' in G0 Table
  • 7078f10 Fixed 708 pen handling from line by line to correct
  • ddbd037 Added max macro for non-Visual Studio IDE

📊 Changes

5 files changed (+130 additions, -55 deletions)

View changed files

📝 src/lib_ccx/ccx_common_platform.h (+4 -0)
📝 src/lib_ccx/ccx_decoders_708.c (+28 -11)
📝 src/lib_ccx/ccx_decoders_708.h (+9 -4)
📝 src/lib_ccx/ccx_decoders_708_encoding.h (+2 -0)
📝 src/lib_ccx/ccx_decoders_708_output.c (+87 -40)

📄 Description

Closes #632
Result files: USA.srt, korean.srt, and others works well

TODO:

  • Make SAMI/TTXT compatible, and after maybe other formats
  • Kick class for characters in CEA-708
  • Fix timing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/640 **Author:** [@Izaron](https://github.com/Izaron) **Created:** 1/12/2017 **Status:** ✅ Merged **Merged:** 1/12/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `subs-708` --- ### 📝 Commits (4) - [`ebd9fc4`](https://github.com/CCExtractor/ccextractor/commit/ebd9fc4bfef4f7f4f3a184f09da1c61f490088d6) Minor mistake in bitsream fixed - [`ddce582`](https://github.com/CCExtractor/ccextractor/commit/ddce5829d5068e8cf6aaae5fc6bb7f42107a18d6) Musical note should replace 'Delete' in G0 Table - [`7078f10`](https://github.com/CCExtractor/ccextractor/commit/7078f1015024d68115d8659a9187224d0d7ad363) Fixed 708 pen handling from line by line to correct - [`ddbd037`](https://github.com/CCExtractor/ccextractor/commit/ddbd03760b9ef125f89c43808a2948d150f836fa) Added max macro for non-Visual Studio IDE ### 📊 Changes **5 files changed** (+130 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_platform.h` (+4 -0) 📝 `src/lib_ccx/ccx_decoders_708.c` (+28 -11) 📝 `src/lib_ccx/ccx_decoders_708.h` (+9 -4) 📝 `src/lib_ccx/ccx_decoders_708_encoding.h` (+2 -0) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+87 -40) </details> ### 📄 Description Closes #632 Result files: [USA.srt](http://paste.ubuntu.com/23787980/), [korean.srt](https://paste.ubuntu.com/23787995/), and others works well TODO: - Make SAMI/TTXT compatible, and after maybe other formats - Kick class for characters in CEA-708 - Fix timing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:16:44 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1489