[PR #1489] [CLOSED] [IMPROVEMENT] adding the release flag to cargo build in linux/build #2214

Open
opened 2026-01-29 17:20:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1489
Author: @ArchitBhonsle
Created: 3/8/2023
Status: Closed

Base: masterHead: build-script-rust-opt


📝 Commits (2)

  • d886c96 adding the release flag to cargo build in linux/build
  • d8e9587 use libccx_rust.a from the release directory in linux/build

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 linux/build (+3 -3)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

I noticed that the Linux build script did not compile Rust with the release flag. I haven't mentioned this in the changelog because I'm not sure if it qualifies to make that list.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1489 **Author:** [@ArchitBhonsle](https://github.com/ArchitBhonsle) **Created:** 3/8/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `build-script-rust-opt` --- ### 📝 Commits (2) - [`d886c96`](https://github.com/CCExtractor/ccextractor/commit/d886c969deb8792ad94cd669b91221a1c00c30e2) adding the release flag to `cargo build` in linux/build - [`d8e9587`](https://github.com/CCExtractor/ccextractor/commit/d8e9587b26db0923f076603c7cff3a871817d9f5) use `libccx_rust.a` from the release directory in linux/build ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `linux/build` (+3 -3) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- I noticed that the Linux `build` script did not compile Rust with the release flag. I haven't mentioned this in the changelog because I'm not sure if it qualifies to make that list. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:20:53 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2214