[PR #742] [MERGED] [Fix][IMPROVEMENT] CMake build for windows. #1561

New Issue

claunia · 2026-01-29T17:17:12Z

claunia commented

2026-01-29 17:17:12 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/742
Author: @saurabhshri
Created: 6/3/2017
Status: ✅ Merged
Merged: 6/5/2017
Merged by: @cfsmp3

Base: master ← Head: cmake-win-fix

📝 Commits (1)

51d936b Fix CMake build for windows.

📊 Changes

2 files changed (+19 additions, -8 deletions)

View changed files

📝 .gitignore (+1 -1)
📝 src/CMakeLists.txt (+18 -7)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

CMake now works successfully on Windows.

added missing libraries
fixed broken linker flags

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/742 **Author:** [@saurabhshri](https://github.com/saurabhshri) **Created:** 6/3/2017 **Status:** ✅ Merged **Merged:** 6/5/2017 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `cmake-win-fix` --- ### 📝 Commits (1) - [`51d936b`](https://github.com/CCExtractor/ccextractor/commit/51d936bc9076e131b4e8b089c664251c3d2f2861) Fix CMake build for windows. ### 📊 Changes **2 files changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -1) 📝 `src/CMakeLists.txt` (+18 -7) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- CMake now works successfully on Windows. - added missing libraries - fixed broken linker flags --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:12 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1561