[PR #833] [MERGED] [FIX] Make CMakeFiles work with Windows Visual Studio #1651

New Issue

claunia · 2026-01-29T17:17:46Z

claunia commented

2026-01-29 17:17:46 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/833
Author: @harrynull
Created: 12/12/2017
Status: ✅ Merged
Merged: 12/16/2017
Merged by: @anshul1912

Base: master ← Head: cmake-windows

📝 Commits (2)

d70c81d Make CMake work with Windows
4263a34 Turn on optimization

📊 Changes

2 files changed (+19 additions, -4 deletions)

View changed files

📝 src/CMakeLists.txt (+10 -3)
📝 src/lib_ccx/CMakeLists.txt (+9 -1)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Make CMakeFiles work with Windows Visual Studio

Fix #812

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/833 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 12/12/2017 **Status:** ✅ Merged **Merged:** 12/16/2017 **Merged by:** [@anshul1912](https://github.com/anshul1912) **Base:** `master` ← **Head:** `cmake-windows` --- ### 📝 Commits (2) - [`d70c81d`](https://github.com/CCExtractor/ccextractor/commit/d70c81d1d193e1875adeaad13f5d1c290f3288ac) Make CMake work with Windows - [`4263a34`](https://github.com/CCExtractor/ccextractor/commit/4263a341e1d67b4d2131b14caaf023392532848d) Turn on optimization ### 📊 Changes **2 files changed** (+19 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/CMakeLists.txt` (+10 -3) 📝 `src/lib_ccx/CMakeLists.txt` (+9 -1) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Make CMakeFiles work with Windows Visual Studio Fix #812 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:17:46 +00:00

claunia referenced this issue

2026-01-29 17:21:44 +00:00

[PR #1651] [CLOSED] [FEAT] Removed `share` module from lib_ccx #2360

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#1651