[PR #1651] [CLOSED] [FEAT] Removed `share` module from lib_ccx

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1651 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 1/5/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `migration-share-module` --- ### 📝 Commits (9) - [`90578ea`](https://github.com/CCExtractor/ccextractor/commit/90578eaf9dfe3dd0a3c469819317df449a2f97e1) replaced nanomsg with nanomsg_sys - [`da6b1e5`](https://github.com/CCExtractor/ccextractor/commit/da6b1e51b29e5683aacd460b29c37745392e5f2e) feat: Share Module - squash commits - [`d8dd4c9`](https://github.com/CCExtractor/ccextractor/commit/d8dd4c9de5101b8325765407236b0ef7a34cd36a) Share Module: Added Documentation - [`1d8b363`](https://github.com/CCExtractor/ccextractor/commit/1d8b36309effbcbdf9598bdf60a5b50bc898f1c3) Share Module: Removed Sharing Service - [`b9cb261`](https://github.com/CCExtractor/ccextractor/commit/b9cb261adcd4879c38e7fa3a44c487ff79d29d4c) Merge branch 'master' into migration-share-module - [`20a32a5`](https://github.com/CCExtractor/ccextractor/commit/20a32a5b53bf688aa86326d5151ed1a4b0b4fa22) Share: formatting issues - [`009febe`](https://github.com/CCExtractor/ccextractor/commit/009febeab360effc1b1169a9d8a56139274d3f16) Share: failing CI - [`c3e4717`](https://github.com/CCExtractor/ccextractor/commit/c3e471784594a581cd66a68723003da6fc50d3e5) Share: failing CI - [`a0b2ca2`](https://github.com/CCExtractor/ccextractor/commit/a0b2ca28c96357465d0d9154d94a1b53280a44c1) Share: Removed protobuf ### 📊 Changes **44 files changed** (+182 additions, -5727 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_linux.yml` (+1 -1) 📝 `.github/workflows/build_mac.yml` (+1 -1) 📝 `.gitignore` (+0 -2) 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `docs/using_cmake_build.txt` (+1 -4) 📝 `linux/Makefile.am` (+2 -8) 📝 `linux/build` (+2 -3) 📝 `linux/module_generator` (+1 -2) 📝 `mac/Makefile.am` (+2 -8) 📝 `mac/build.command` (+2 -3) 📝 `src/BUILD` (+1 -2) 📝 `src/CMakeLists.txt` (+0 -18) 📝 `src/ccextractor.c` (+0 -25) 📝 `src/ccextractor.h` (+0 -1) 📝 `src/lib_ccx/BUILD` (+2 -4) 📝 `src/lib_ccx/CMakeLists.txt` (+0 -3) 📝 `src/lib_ccx/ccx_common_constants.h` (+0 -3) 📝 `src/lib_ccx/ccx_common_option.c` (+0 -7) 📝 `src/lib_ccx/ccx_common_option.h` (+0 -11) 📝 `src/lib_ccx/ccx_encoders_common.c` (+0 -8) _...and 24 more files_ </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- {pull request content here} This PR migrates the sharing service used by the cctranslate service. The first draft was added on 5/1/2025. The new rust Implentation is in `/src/rust/lib_ccxr/src/share/`. **Changes Made** - The Rust file containing the main translated logic is in `/src/rust/lib_ccxr/src/share/share.rs` - The Rust file `/src/rust/lib_ccxr/src/share/tests.rs` contains some preliminary tests. - The File `/src/rust/src/libccxr_exports/share.rs`contains the C bindings, as per doc specification - The [nanomsg library](https://github.com/thehydroimpulse/nanomsg.rs) for rust is being used in this code, just like the nanomsg library is used in the C code. The tests have all ran successfully, although I feel like that the current tests may not be enough to test it out completely. - I've also made some changes in the build commands of Linux and Mac to make them build successfully. It does for Linux, as far as I've tested. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:21:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1651
Author: @steel-bucket
Created: 1/5/2025
Status: ❌ Closed

Base: master ← Head: migration-share-module

📝 Commits (9)

90578ea replaced nanomsg with nanomsg_sys
da6b1e5 feat: Share Module - squash commits
d8dd4c9 Share Module: Added Documentation
1d8b363 Share Module: Removed Sharing Service
b9cb261 Merge branch 'master' into migration-share-module
20a32a5 Share: formatting issues
009febe Share: failing CI
c3e4717 Share: failing CI
a0b2ca2 Share: Removed protobuf

📊 Changes

44 files changed (+182 additions, -5727 deletions)

View changed files

📝 .github/workflows/build_linux.yml (+1 -1)
📝 .github/workflows/build_mac.yml (+1 -1)
📝 .gitignore (+0 -2)
📝 docs/CHANGES.TXT (+1 -0)
📝 docs/using_cmake_build.txt (+1 -4)
📝 linux/Makefile.am (+2 -8)
📝 linux/build (+2 -3)
📝 linux/module_generator (+1 -2)
📝 mac/Makefile.am (+2 -8)
📝 mac/build.command (+2 -3)
📝 src/BUILD (+1 -2)
📝 src/CMakeLists.txt (+0 -18)
📝 src/ccextractor.c (+0 -25)
📝 src/ccextractor.h (+0 -1)
📝 src/lib_ccx/BUILD (+2 -4)
📝 src/lib_ccx/CMakeLists.txt (+0 -3)
📝 src/lib_ccx/ccx_common_constants.h (+0 -3)
📝 src/lib_ccx/ccx_common_option.c (+0 -7)
📝 src/lib_ccx/ccx_common_option.h (+0 -11)
📝 src/lib_ccx/ccx_encoders_common.c (+0 -8)

...and 24 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

{pull request content here}
This PR migrates the sharing service used by the cctranslate service. The first draft was added on 5/1/2025. The new rust Implentation is in /src/rust/lib_ccxr/src/share/.

Changes Made

The Rust file containing the main translated logic is in /src/rust/lib_ccxr/src/share/share.rs
The Rust file /src/rust/lib_ccxr/src/share/tests.rs contains some preliminary tests.
The File /src/rust/src/libccxr_exports/share.rscontains the C bindings, as per doc specification
The nanomsg library for rust is being used in this code, just like the nanomsg library is used in the C code. The tests have all ran successfully, although I feel like that the current tests may not be enough to test it out completely.
I've also made some changes in the build commands of Linux and Mac to make them build successfully. It does for Linux, as far as I've tested.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:21:44 +00:00

claunia closed this issue

[PR #1651] [CLOSED] [FEAT] Removed share module from lib_ccx #2360

📋 Pull Request Information

📝 Commits (9)

📊 Changes

📄 Description

[PR #1651] [CLOSED] [FEAT] Removed `share` module from lib_ccx #2360