[PR #849] [CLOSED] [IMPROVEMENT] Checks for text before newlines on DVB subtitles #1675

Open
opened 2026-01-29 17:17:54 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/849
Author: @ghost
Created: 12/26/2017
Status: Closed

Base: masterHead: master


📝 Commits (4)

  • 4e3ece7 reworks scanning newlines to look for content in a line
  • 039159d reworks bool to int
  • fde6425 reworks function to scan only for control characters, pushes up instead of breaking
  • 45a87c8 breaks if a character found to preserve horizontal positioning

📊 Changes

1 file changed (+16 additions, -7 deletions)

View changed files

📝 src/lib_ccx/ocr.c (+16 -7)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

Resolves the multiple lines issue of https://github.com/CCExtractor/ccextractor/issues/840, basically does the same thing that https://github.com/CCExtractor/ccextractor/pull/844 does but without raising potential issues with newlines as pointed out in the codein task.

Repeat of https://github.com/CCExtractor/ccextractor/pull/847 thank you github for automatically closing my PR for no reason


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/849 **Author:** [@ghost](https://github.com/ghost) **Created:** 12/26/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`4e3ece7`](https://github.com/CCExtractor/ccextractor/commit/4e3ece78a2bff696ec8961a1b8b4a49e4bc09ffd) reworks scanning newlines to look for content in a line - [`039159d`](https://github.com/CCExtractor/ccextractor/commit/039159d5abaaa9eea155b249d64e6b0f2d32c913) reworks bool to int - [`fde6425`](https://github.com/CCExtractor/ccextractor/commit/fde64250157ef6226e0939880fb938544309ac41) reworks function to scan only for control characters, pushes up instead of breaking - [`45a87c8`](https://github.com/CCExtractor/ccextractor/commit/45a87c8aca5af97e3b4c677d0d3b32b5edc12d9b) breaks if a character found to preserve horizontal positioning ### 📊 Changes **1 file changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ocr.c` (+16 -7) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Resolves the multiple lines issue of https://github.com/CCExtractor/ccextractor/issues/840, basically does the same thing that https://github.com/CCExtractor/ccextractor/pull/844 does but without raising potential issues with newlines as pointed out in the codein task. Repeat of https://github.com/CCExtractor/ccextractor/pull/847 thank you github for automatically closing my PR for no reason --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:17:54 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1675