mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-04 05:44:53 +00:00
[PR #849] [CLOSED] [IMPROVEMENT] Checks for text before newlines on DVB subtitles #1675
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/CCExtractor/ccextractor/pull/849
Author: @ghost
Created: 12/26/2017
Status: ❌ Closed
Base:
master← Head:master📝 Commits (4)
4e3ece7reworks scanning newlines to look for content in a line039159dreworks bool to intfde6425reworks function to scan only for control characters, pushes up instead of breaking45a87c8breaks if a character found to preserve horizontal positioning📊 Changes
1 file changed (+16 additions, -7 deletions)
View changed files
📝
src/lib_ccx/ocr.c(+16 -7)📄 Description
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Resolves the multiple lines issue of https://github.com/CCExtractor/ccextractor/issues/840, basically does the same thing that https://github.com/CCExtractor/ccextractor/pull/844 does but without raising potential issues with newlines as pointed out in the codein task.
Repeat of https://github.com/CCExtractor/ccextractor/pull/847 thank you github for automatically closing my PR for no reason
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.