starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-04-28 17:10:33 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1678] [CLOSED] [WIP][FEAT]: Add module decoder_vbi in lib_ccxr #2393

New Issue
Open
opened 2026-01-29 17:21:54 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:54 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1678
Author: @vatsalkeshav
Created: 3/21/2025
Status: ❌ Closed

Base: master ← Head: vbi_migration

📝 Commits (7)

  • 99e1609 feat: added vbis module in lib_ccxr
  • f116ed3 fixed cargo --clippy errors
  • 0443814 rust : fixed some common errors
  • feb97f1 fix: CMake builds failing due to oudated corrosion (#1677)
  • 7f008d6 [FIX] DVB OCR: Memory Leak & Quantization Issues (#1675)
  • 7b58488 [FIX] Issue#1665 Enhanced Matroska Language Tag Handling (#1671)
  • 0241a64 code refactoring

📊 Changes

21 files changed (+2217 additions, -58 deletions)

View changed files

📝 docker/dockerfile (+2 -2)
📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_common_timing.c (+1 -0)
📝 src/lib_ccx/ccx_decoders_vbi.c (+1 -0)
📝 src/lib_ccx/matroska.c (+92 -27)
📝 src/lib_ccx/matroska.h (+2 -0)
📝 src/lib_ccx/ocr.c (+24 -27)
📝 src/lib_ccx/zvbi/raw_decoder.c (+1 -1)
📝 src/rust/CMakeLists.txt (+1 -1)
📝 src/rust/Cargo.lock (+102 -0)
📝 src/rust/Cargo.toml (+6 -0)
📝 src/rust/lib_ccxr/Cargo.toml (+6 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/exit_codes.rs (+102 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/functions_vbi.rs (+130 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/mod.rs (+7 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_ccdecode.rs (+280 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_isdb.rs (+794 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_vbi.rs (+268 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_xds.rs (+395 -0)
📝 src/rust/lib_ccxr/src/lib.rs (+1 -0)

...and 1 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_vbi.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_isdb/functions_vbi_main.rs (helpers in functions_vbi_slice.rs, functions_vbi_decode.rs, vbi_service_table.rs)
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_isdb, structs_xds.rs, structs_isdb.rs, structs_ccdecode.rs, structs_vbi_slice.rs, structs_vbi_decode.rs
  3. Exit codes etc in /src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1678 **Author:** [@vatsalkeshav](https://github.com/vatsalkeshav) **Created:** 3/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `vbi_migration` --- ### 📝 Commits (7) - [`99e1609`](https://github.com/CCExtractor/ccextractor/commit/99e16092410f09381356fd060c4b556eba776025) feat: added vbis module in lib_ccxr - [`f116ed3`](https://github.com/CCExtractor/ccextractor/commit/f116ed3e289601d06be2294ded4157dde3905206) fixed cargo --clippy errors - [`0443814`](https://github.com/CCExtractor/ccextractor/commit/04438141eed98069b5bb5beec71ce67b8aa4b3d4) rust : fixed some common errors - [`feb97f1`](https://github.com/CCExtractor/ccextractor/commit/feb97f13da0aa72c0833a4b08360351d6f1edc8a) fix: CMake builds failing due to oudated corrosion (#1677) - [`7f008d6`](https://github.com/CCExtractor/ccextractor/commit/7f008d6134fde4399f86e924e8cda715b5b94368) [FIX] DVB OCR: Memory Leak & Quantization Issues (#1675) - [`7b58488`](https://github.com/CCExtractor/ccextractor/commit/7b5848813e3374b7bcdfd3a144f3ba282c88c4e2) [FIX] Issue#1665 Enhanced Matroska Language Tag Handling (#1671) - [`0241a64`](https://github.com/CCExtractor/ccextractor/commit/0241a64f06d0030b236b9c4fb50a26e9ec64df0b) code refactoring ### 📊 Changes **21 files changed** (+2217 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `docker/dockerfile` (+2 -2) 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_common_timing.c` (+1 -0) 📝 `src/lib_ccx/ccx_decoders_vbi.c` (+1 -0) 📝 `src/lib_ccx/matroska.c` (+92 -27) 📝 `src/lib_ccx/matroska.h` (+2 -0) 📝 `src/lib_ccx/ocr.c` (+24 -27) 📝 `src/lib_ccx/zvbi/raw_decoder.c` (+1 -1) 📝 `src/rust/CMakeLists.txt` (+1 -1) 📝 `src/rust/Cargo.lock` (+102 -0) 📝 `src/rust/Cargo.toml` (+6 -0) 📝 `src/rust/lib_ccxr/Cargo.toml` (+6 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/exit_codes.rs` (+102 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/functions_vbi.rs` (+130 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/mod.rs` (+7 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_ccdecode.rs` (+280 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_isdb.rs` (+794 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_vbi.rs` (+268 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_xds.rs` (+395 -0) 📝 `src/rust/lib_ccxr/src/lib.rs` (+1 -0) _...and 1 more files_ </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR migrates `/src/lib_ccx/ccx_decoders_vbi.c` to rust. These changes have been made- 1. Pure rust equivalent functions in `/src/rust/lib_ccxr/src/decoder_isdb/functions_vbi_main.rs` (helpers in `functions_vbi_slice.rs`, `functions_vbi_decode.rs`, `vbi_service_table.rs`) 2. Required datatypes in `/src/rust/lib_ccxr/src/decoder_isdb, structs_xds.rs`, `structs_isdb.rs`, `structs_ccdecode.rs`, `structs_vbi_slice.rs`, `structs_vbi_decode.rs` 3. Exit codes etc in `/src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?