[PR #849] [IMPROVEMENT] Checks for text before newlines on DVB subtitles #1679

Closed
opened 2026-01-29 17:17:55 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/849

State: closed
Merged: No


Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

Resolves the multiple lines issue of https://github.com/CCExtractor/ccextractor/issues/840, basically does the same thing that https://github.com/CCExtractor/ccextractor/pull/844 does but without raising potential issues with newlines as pointed out in the codein task.

Repeat of https://github.com/CCExtractor/ccextractor/pull/847 thank you github for automatically closing my PR for no reason

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/849 **State:** closed **Merged:** No --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I have used CCExtractor just a couple of times. --- Resolves the multiple lines issue of https://github.com/CCExtractor/ccextractor/issues/840, basically does the same thing that https://github.com/CCExtractor/ccextractor/pull/844 does but without raising potential issues with newlines as pointed out in the codein task. Repeat of https://github.com/CCExtractor/ccextractor/pull/847 thank you github for automatically closing my PR for no reason
claunia added the pull-request label 2026-01-29 17:17:55 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1679