[PR #1679] [CLOSED] [FEAT] Add module decoder_xds to lib_ccxr #2392

Open
opened 2026-01-29 17:21:54 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1679
Author: @vatsalkeshav
Created: 3/26/2025
Status: Closed

Base: masterHead: xds-migration


📝 Commits (2)

  • 4618772 feat : added module decoder_xds in lib_ccxr
  • 9f03ab4 some serious code refactoring

📊 Changes

13 files changed (+1561 additions, -3 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_xds.c (+40 -0)
📝 src/lib_ccx/ccx_decoders_xds.h (+1 -1)
📝 src/rust/lib_ccxr/src/common/options.rs (+1 -0)
src/rust/lib_ccxr/src/decoder_xds/exit_codes.rs (+43 -0)
src/rust/lib_ccxr/src/decoder_xds/functions_xds.rs (+1083 -0)
src/rust/lib_ccxr/src/decoder_xds/mod.rs (+3 -0)
src/rust/lib_ccxr/src/decoder_xds/structs_xds.rs (+300 -0)
📝 src/rust/lib_ccxr/src/lib.rs (+1 -0)
📝 src/rust/lib_ccxr/src/time/timing.rs (+3 -1)
📝 src/rust/lib_ccxr/src/time/units.rs (+3 -0)
📝 src/rust/src/libccxr_exports/mod.rs (+1 -0)
src/rust/src/libccxr_exports/xds_exports.rs (+81 -0)
📝 src/rust/wrapper.h (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_xds.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_xds/functions_xds.rs
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_xds/structs_xds.rs
  3. C-compatible rust functions/exports in src/rust/src/libccxr_exports/xds_exports.rs
  4. Declaration and use of written rust functions in /src/lib_ccx/ccx_decoders_xds.c
  5. Added some #[repr(C)]s in existing structs

To-do:

  • Unit tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1679 **Author:** [@vatsalkeshav](https://github.com/vatsalkeshav) **Created:** 3/26/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `xds-migration` --- ### 📝 Commits (2) - [`4618772`](https://github.com/CCExtractor/ccextractor/commit/4618772378f1783206bb929fb892e02905d3327c) feat : added module decoder_xds in lib_ccxr - [`9f03ab4`](https://github.com/CCExtractor/ccextractor/commit/9f03ab44335bacf19b9d3805825184f84b9caebe) some serious code refactoring ### 📊 Changes **13 files changed** (+1561 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_xds.c` (+40 -0) 📝 `src/lib_ccx/ccx_decoders_xds.h` (+1 -1) 📝 `src/rust/lib_ccxr/src/common/options.rs` (+1 -0) ➕ `src/rust/lib_ccxr/src/decoder_xds/exit_codes.rs` (+43 -0) ➕ `src/rust/lib_ccxr/src/decoder_xds/functions_xds.rs` (+1083 -0) ➕ `src/rust/lib_ccxr/src/decoder_xds/mod.rs` (+3 -0) ➕ `src/rust/lib_ccxr/src/decoder_xds/structs_xds.rs` (+300 -0) 📝 `src/rust/lib_ccxr/src/lib.rs` (+1 -0) 📝 `src/rust/lib_ccxr/src/time/timing.rs` (+3 -1) 📝 `src/rust/lib_ccxr/src/time/units.rs` (+3 -0) 📝 `src/rust/src/libccxr_exports/mod.rs` (+1 -0) ➕ `src/rust/src/libccxr_exports/xds_exports.rs` (+81 -0) 📝 `src/rust/wrapper.h` (+1 -1) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR migrates `/src/lib_ccx/ccx_decoders_xds.c` to rust. These changes have been made- 1. Pure rust equivalent functions in `/src/rust/lib_ccxr/src/decoder_xds/functions_xds.rs` 2. Required datatypes in `/src/rust/lib_ccxr/src/decoder_xds/structs_xds.rs` 3. C-compatible rust functions/exports in `src/rust/src/libccxr_exports/xds_exports.rs` 4. Declaration and use of written rust functions in `/src/lib_ccx/ccx_decoders_xds.c` 5. Added some `#[repr(C)]`s in existing structs **To-do:** - [ ] Unit tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:54 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2392