[PR #904] [MERGED] [FIX] Fix incorrect path in XML (spupng) #1742

Open
opened 2026-01-29 17:18:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/904
Author: @harrynull
Created: 1/19/2018
Status: Merged
Merged: 1/19/2018
Merged by: @cfsmp3

Base: masterHead: spupng-patch


📝 Commits (1)

  • c03b7e6 Fix incorrect path in XML

📊 Changes

1 file changed (+11 additions, -5 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_spupng.c (+11 -5)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The path in generated XML (spupng) was always sub0000.png. This patch fixs it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/904 **Author:** [@harrynull](https://github.com/harrynull) **Created:** 1/19/2018 **Status:** ✅ Merged **Merged:** 1/19/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `spupng-patch` --- ### 📝 Commits (1) - [`c03b7e6`](https://github.com/CCExtractor/ccextractor/commit/c03b7e6e2c6a543024351efa5544c66b89384500) Fix incorrect path in XML ### 📊 Changes **1 file changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_spupng.c` (+11 -5) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- The path in generated XML (spupng) was always `sub0000.png`. This patch fixs it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:17 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1742