[PR #1742] [MERGED] Fix --ocrlang argument on rust #2464

Open
opened 2026-01-29 17:22:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1742
Author: @hrideshmg
Created: 9/1/2025
Status: Merged
Merged: 9/1/2025
Merged by: @prateekmedia

Base: masterHead: ocrlang_fix


📝 Commits (1)

  • 2494d7e fix: ocrlang argument not working

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 src/rust/lib_ccxr/src/common/options.rs (+1 -1)
📝 src/rust/src/common.rs (+2 -2)
📝 src/rust/src/parser.rs (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The --ocrlang argument currently doesn't work as expected as it expects to be passed a file path on Rust but the rest of the codebase expects it to be language code of the .traineddata file


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1742 **Author:** [@hrideshmg](https://github.com/hrideshmg) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `ocrlang_fix` --- ### 📝 Commits (1) - [`2494d7e`](https://github.com/CCExtractor/ccextractor/commit/2494d7e05399613e92a75286a01fe3390478ca43) fix: ocrlang argument not working ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/lib_ccxr/src/common/options.rs` (+1 -1) 📝 `src/rust/src/common.rs` (+2 -2) 📝 `src/rust/src/parser.rs` (+1 -1) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [ ] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [ ] I have checked that another pull request for this purpose does not exist. - [ ] I have considered, and confirmed that this submission will be valuable to others. - [ ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [ ] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- The `--ocrlang` argument currently doesn't work as expected as it expects to be passed a file path on Rust but the rest of the codebase expects it to be language code of the `.traineddata` file --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:17 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2464