[PR #950] [MERGED] [FIX] Fix segfault in add_cc_sub_text and initialize to NULL in init_encoder #1775

New Issue

claunia · 2026-01-29T17:18:29Z

claunia commented

2026-01-29 17:18:29 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/950
Author: @saurabhshah0410
Created: 3/3/2018
Status: ✅ Merged
Merged: 3/5/2018
Merged by: @cfsmp3

Base: master ← Head: bugfix

📝 Commits (1)

8a7367a Fix segfault in add_cc_sub_text and initialize to NULL in init_encoder

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 src/lib_ccx/ccx_common_common.c (+2 -0)
📝 src/lib_ccx/ccx_encoders_common.c (+1 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This commit adds some checks to avoid segmentation faults.

In add_cc_sub_text(), strdup will cause a segfault if we duplicate an
empty string.
In init_encoder(), initialize pointer fields to NULL to avoid random
addressing so we can avoid illegal memory accessing and segfaults in
other places.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/950 **Author:** [@saurabhshah0410](https://github.com/saurabhshah0410) **Created:** 3/3/2018 **Status:** ✅ Merged **Merged:** 3/5/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `bugfix` --- ### 📝 Commits (1) - [`8a7367a`](https://github.com/CCExtractor/ccextractor/commit/8a7367a5a9af1ba044ce01d8ff9678f5103c4218) Fix segfault in add_cc_sub_text and initialize to NULL in init_encoder ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_common_common.c` (+2 -0) 📝 `src/lib_ccx/ccx_encoders_common.c` (+1 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This commit adds some checks to avoid segmentation faults. * In `add_cc_sub_text()`, strdup will cause a segfault if we duplicate an empty string. * In `init_encoder()`, initialize pointer fields to NULL to avoid random addressing so we can avoid illegal memory accessing and segfaults in other places. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:29 +00:00

claunia referenced this issue

2026-01-29 17:22:29 +00:00

[PR #1775] [CLOSED] Fix Teletext page detection in report mode (Fixes #1034) #2502

claunia referenced this issue

2026-01-29 17:22:29 +00:00

[PR #1775] Fix Teletext page detection in report mode (Fixes #1034) #2505

Sign in to join this conversation.