[PR #1775] [CLOSED] Fix Teletext page detection in report mode (Fixes #1034) #2502

New Issue

claunia · 2026-01-29T17:22:29Z

claunia commented

2026-01-29 17:22:29 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1775
Author: @Rahul-2k4
Created: 12/5/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

51b862f Add teletext report functionality to general_loop.c
95efa93 Initial plan
69672c8 Add changelog entry for Teletext report mode fix
dcc01e7 Merge pull request #1 from Rahul-2k4/copilot/fix-teletext-page-detection
349ca6a Initial plan
80f78f1 Initial plan for fixing formatting issues
8c2e54a Merge pull request #2 from Rahul-2k4/copilot/fix-formatting-issues
1ff7368 Initial plan
95661df Update vcpkg baseline to fix libxml2 hash mismatch
d6b7052 Merge pull request #3 from Rahul-2k4/copilot/update-libxml2-hash

📊 Changes

8 files changed (+152 additions, -167 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 docs/OCR.md (+16 -0)
📝 src/lib_ccx/general_loop.c (+8 -3)
📝 src/lib_ccx/hardsubx_decoder.c (+28 -7)
📝 src/lib_ccx/ocr.c (+50 -5)
📝 src/rust/Cargo.lock (+7 -140)
📝 src/rust/src/hardsubx/classifier.rs (+31 -1)
📝 windows/vcpkg.json (+11 -11)

📄 Description

This pull request updates the Teletext processing logic in the process_data function to allow Teletext extraction in both normal extraction mode and report mode. The main change is to enable Teletext processing even when the encoder context (enc_ctx) is not present, as long as file reports are being printed.

Teletext extraction improvements:

Modified the conditional in process_data (in src/lib_ccx/general_loop.c) to allow Teletext processing when either enc_ctx is present or ccx_options.print_file_reports is enabled, enabling Teletext extraction in report mode.
Updated the call to tlt_process_pes_packet to use a default sentence_cap of 0 when enc_ctx is not available, ensuring correct behavior in report mode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1775 **Author:** [@Rahul-2k4](https://github.com/Rahul-2k4) **Created:** 12/5/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`51b862f`](https://github.com/CCExtractor/ccextractor/commit/51b862f7c52505799e778e6e34cf4d7dc650e46f) Add teletext report functionality to general_loop.c - [`95efa93`](https://github.com/CCExtractor/ccextractor/commit/95efa9327b2a8fda0a9bf48fdfae15b391e1b12f) Initial plan - [`69672c8`](https://github.com/CCExtractor/ccextractor/commit/69672c813c96671598c25728b4da86e2901e2820) Add changelog entry for Teletext report mode fix - [`dcc01e7`](https://github.com/CCExtractor/ccextractor/commit/dcc01e786e4d1207b66c2ecb0a8829499f80c5b6) Merge pull request #1 from Rahul-2k4/copilot/fix-teletext-page-detection - [`349ca6a`](https://github.com/CCExtractor/ccextractor/commit/349ca6aaec0a878471068dd5cb24cb1f73196843) Initial plan - [`80f78f1`](https://github.com/CCExtractor/ccextractor/commit/80f78f171de56e9f8658a607e739071efff5d3b9) Initial plan for fixing formatting issues - [`8c2e54a`](https://github.com/CCExtractor/ccextractor/commit/8c2e54ab4acac93ba02ec7e4279d41296fad4893) Merge pull request #2 from Rahul-2k4/copilot/fix-formatting-issues - [`1ff7368`](https://github.com/CCExtractor/ccextractor/commit/1ff73685558199bf22f6c5f8fa14e2fddf1617a2) Initial plan - [`95661df`](https://github.com/CCExtractor/ccextractor/commit/95661dfabfceb99005af9cb4db625046a3aff002) Update vcpkg baseline to fix libxml2 hash mismatch - [`d6b7052`](https://github.com/CCExtractor/ccextractor/commit/d6b70529e1b6bcc0f91b4f0232b613aa3094a784) Merge pull request #3 from Rahul-2k4/copilot/update-libxml2-hash ### 📊 Changes **8 files changed** (+152 additions, -167 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `docs/OCR.md` (+16 -0) 📝 `src/lib_ccx/general_loop.c` (+8 -3) 📝 `src/lib_ccx/hardsubx_decoder.c` (+28 -7) 📝 `src/lib_ccx/ocr.c` (+50 -5) 📝 `src/rust/Cargo.lock` (+7 -140) 📝 `src/rust/src/hardsubx/classifier.rs` (+31 -1) 📝 `windows/vcpkg.json` (+11 -11) </details> ### 📄 Description This pull request updates the Teletext processing logic in the `process_data` function to allow Teletext extraction in both normal extraction mode and report mode. The main change is to enable Teletext processing even when the encoder context (`enc_ctx`) is not present, as long as file reports are being printed. Teletext extraction improvements: * Modified the conditional in `process_data` (in `src/lib_ccx/general_loop.c`) to allow Teletext processing when either `enc_ctx` is present or `ccx_options.print_file_reports` is enabled, enabling Teletext extraction in report mode. * Updated the call to `tlt_process_pes_packet` to use a default `sentence_cap` of 0 when `enc_ctx` is not available, ensuring correct behavior in report mode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:29 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2502