[PR #966] [MERGED] [FEATURE] Allow build with hardsubx using cmake #1785

New Issue

claunia · 2026-01-29T17:18:32Z

claunia commented

2026-01-29 17:18:32 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/966
Author: @thealphadollar
Created: 3/13/2018
Status: ✅ Merged
Merged: 3/13/2018
Merged by: @cfsmp3

Base: master ← Head: cmake-hardsubx

📝 Commits (1)

ebfdecd allow build with hardsubx using cmake

📊 Changes

1 file changed (+29 additions, -0 deletions)

View changed files

📝 src/CMakeLists.txt (+29 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Fixes #964

To allow building with hardsubx, option has been added along with checking for the libraries it requires which have been cross-checked with Makefile.am

3d6a9f4d57/linux/Makefile.am (L330)

Below is the build result after implementing the changes and using cmake.

make -j8 was successful in compiling the source code. Below is the command used on a file to test.

The required library for building with FFMPEG, "avfilter", was not listed in the required libraries and hence has been added to it. This was done in response to an error caused at the time of testing (due to absence of libavfilter-dev in my system), below is the error. Parameters used:
cd ./build
cmake -DWITH_FFMPEG=ON ../src/
make -j8

The tests were also done on a remote Digital Ocean droplet by forking the branch and hence are system independent and are working.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/966 **Author:** [@thealphadollar](https://github.com/thealphadollar) **Created:** 3/13/2018 **Status:** ✅ Merged **Merged:** 3/13/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `cmake-hardsubx` --- ### 📝 Commits (1) - [`ebfdecd`](https://github.com/CCExtractor/ccextractor/commit/ebfdecd9b222bee4d77fdfe27d09904e206e4cc0) allow build with hardsubx using cmake ### 📊 Changes **1 file changed** (+29 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/CMakeLists.txt` (+29 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- Fixes #964 To allow building with hardsubx, option has been added along with checking for the libraries it requires which have been cross-checked with Makefile.am https://github.com/CCExtractor/ccextractor/blob/3d6a9f4d57e5fb63b004f5b341a310e8d931f7cf/linux/Makefile.am#L330 Below is the build result after implementing the changes and using cmake. ![screenshot from 2018-03-14 00-16-08](https://user-images.githubusercontent.com/32812320/37363780-cebe1e8e-271e-11e8-8068-00efdf33cc66.png) `make -j8` was successful in compiling the source code. Below is the command used on a file to test. ![screenshot from 2018-03-14 00-16-33](https://user-images.githubusercontent.com/32812320/37363861-038c59e6-271f-11e8-8023-6f6aea432fe2.png) The required library for building with FFMPEG, "avfilter", was not listed in the required libraries and hence has been added to it. This was done in response to an error caused at the time of testing (due to absence of libavfilter-dev in my system), below is the error. Parameters used: `cd ./build` `cmake -DWITH_FFMPEG=ON ../src/` `make -j8` ![screenshot from 2018-03-14 00-13-29](https://user-images.githubusercontent.com/32812320/37363971-3c6b2788-271f-11e8-9eec-6ac512783fa2.png) The tests were also done on a remote Digital Ocean droplet by forking the branch and hence are system independent and are working. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:18:32 +00:00

claunia closed this issue

2026-01-29 17:18:32 +00:00

claunia referenced this issue

2026-01-29 17:22:34 +00:00

[PR #1785] [CLOSED] Fix #1779: Update COMPILATION.md to reflect correct Linux build flags #2518

claunia referenced this issue

2026-01-29 17:22:34 +00:00

[PR #1785] Fix #1779: Update COMPILATION.md to reflect correct Linux build flags #2522

Sign in to join this conversation.