[PR #974] [MERGED] [IMPROVEMENT] Update libGPAC #1787

Open
opened 2026-01-29 17:18:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/974
Author: @thealphadollar
Created: 4/19/2018
Status: Merged
Merged: 4/23/2018
Merged by: @cfsmp3

Base: masterHead: update_gpac


📝 Commits (3)

📊 Changes

42 files changed (+2152 additions, -686 deletions)

View changed files

docs/Updating_Dependencies.txt (+27 -0)
📝 src/gpacmp4/avc_ext.c (+117 -63)
📝 src/gpacmp4/base_encoding.c (+23 -7)
📝 src/gpacmp4/bitstream.c (+84 -22)
📝 src/gpacmp4/box_code_3gpp.c (+1 -1)
📝 src/gpacmp4/box_code_base.c (+80 -21)
📝 src/gpacmp4/box_code_drm.c (+13 -6)
📝 src/gpacmp4/box_code_meta.c (+13 -9)
📝 src/gpacmp4/box_dump.c (+13 -2)
📝 src/gpacmp4/box_funcs.c (+38 -26)
📝 src/gpacmp4/data_map.c (+31 -14)
📝 src/gpacmp4/descriptors.c (+103 -63)
📝 src/gpacmp4/drm_sample.c (+42 -25)
📝 src/gpacmp4/error.c (+17 -2)
📝 src/gpacmp4/gpac/bitstream.h (+31 -4)
📝 src/gpacmp4/gpac/constants.h (+184 -11)
📝 src/gpacmp4/gpac/events_constants.h (+1 -0)
📝 src/gpacmp4/gpac/internal/isomedia_dev.h (+144 -107)
📝 src/gpacmp4/gpac/internal/media_dev.h (+13 -1)
src/gpacmp4/gpac/iso639.h (+89 -0)

...and 22 more files

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I am an active contributor to CCExtractor.

We use libGPAC for all our MP4 operations and, this commit updates it to the latest version.

All previous changes to the original library were restored post straight file updation and bugs have been removed.

concerns #961

The updated libGPAC supports the file present in the referenced issue but, unfortunately, the new library is detecting that there are no subtitles in the file.

screenshot from 2018-04-20 02-05-12

change severity: very high


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/974 **Author:** [@thealphadollar](https://github.com/thealphadollar) **Created:** 4/19/2018 **Status:** ✅ Merged **Merged:** 4/23/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `update_gpac` --- ### 📝 Commits (3) - [`43ca87b`](https://github.com/CCExtractor/ccextractor/commit/43ca87bf7a2b2d976618abda74fb02ce5fce7d55) Add Updated GPAC - [`7422ae1`](https://github.com/CCExtractor/ccextractor/commit/7422ae1764c80406a1510437b3ef4bf77a6cb9c4) Update libGPAC dependency - [`8301fd1`](https://github.com/CCExtractor/ccextractor/commit/8301fd1638b3fc37cb5255d1e6bdda641b8c4c77) Add Guide To Updating Dependencies ### 📊 Changes **42 files changed** (+2152 additions, -686 deletions) <details> <summary>View changed files</summary> ➕ `docs/Updating_Dependencies.txt` (+27 -0) 📝 `src/gpacmp4/avc_ext.c` (+117 -63) 📝 `src/gpacmp4/base_encoding.c` (+23 -7) 📝 `src/gpacmp4/bitstream.c` (+84 -22) 📝 `src/gpacmp4/box_code_3gpp.c` (+1 -1) 📝 `src/gpacmp4/box_code_base.c` (+80 -21) 📝 `src/gpacmp4/box_code_drm.c` (+13 -6) 📝 `src/gpacmp4/box_code_meta.c` (+13 -9) 📝 `src/gpacmp4/box_dump.c` (+13 -2) 📝 `src/gpacmp4/box_funcs.c` (+38 -26) 📝 `src/gpacmp4/data_map.c` (+31 -14) 📝 `src/gpacmp4/descriptors.c` (+103 -63) 📝 `src/gpacmp4/drm_sample.c` (+42 -25) 📝 `src/gpacmp4/error.c` (+17 -2) 📝 `src/gpacmp4/gpac/bitstream.h` (+31 -4) 📝 `src/gpacmp4/gpac/constants.h` (+184 -11) 📝 `src/gpacmp4/gpac/events_constants.h` (+1 -0) 📝 `src/gpacmp4/gpac/internal/isomedia_dev.h` (+144 -107) 📝 `src/gpacmp4/gpac/internal/media_dev.h` (+13 -1) ➕ `src/gpacmp4/gpac/iso639.h` (+89 -0) _...and 22 more files_ </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [X] I am an active contributor to CCExtractor. --- We use libGPAC for all our MP4 operations and, this commit updates it to the latest version. All previous changes to the original library were restored post straight file updation and bugs have been removed. concerns #961 The updated libGPAC supports the file present in the referenced issue but, unfortunately, the new library is detecting that there are no subtitles in the file. ![screenshot from 2018-04-20 02-05-12](https://user-images.githubusercontent.com/32812320/39016900-6767e27c-443f-11e8-8045-ceca55ae90f0.png) **change severity:** *very high* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:18:33 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#1787