[PR #1787] [CLOSED] Improve -out=report to show detected Teletext subtitle pages (Fixes #1034) #2516

New Issue

claunia · 2026-01-29T17:22:33Z

claunia commented

2026-01-29 17:22:33 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1787
Author: @Rahul-2k4
Created: 12/9/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (6)

9e9023c Initial plan
1f7120f Apply teletext page detection fix from fix branch
ebe25af Fix indentation to use tabs consistently
17a8e1e Remove unintended Cargo.lock changes
f30f276 Apply code style fixes from clang-format
d524a02 Merge pull request #2 from Rahul-2k4/copilot/fix-teletext-page-detection-issue-1034

📊 Changes

2 files changed (+40 additions, -6 deletions)

View changed files

📝 src/lib_ccx/ccx_encoders_common.c (+22 -0)
📝 src/lib_ccx/general_loop.c (+18 -6)

📄 Description

This PR fixes Issue #1034, where running CCExtractor with -out=report does not list Teletext pages that contain possible subtitles, even though the same pages are correctly detected during normal extraction.

In report-only mode, CCExtractor skips Teletext PES packet processing because the encoder context (enc_ctx) is not created. Since subtitle-page detection happens inside Teletext packet parsing, no pages are recorded in seen_sub_page[], resulting in an empty Pages With Subtitles: field in the final report.

This PR enables Teletext detection in -out=report mode and ensures proper memory cleanup when the encoder is absent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1787 **Author:** [@Rahul-2k4](https://github.com/Rahul-2k4) **Created:** 12/9/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`9e9023c`](https://github.com/CCExtractor/ccextractor/commit/9e9023c2586fd16680f6ec0896403ac5f6e1c95b) Initial plan - [`1f7120f`](https://github.com/CCExtractor/ccextractor/commit/1f7120f32fb0f22bb9dcca7adb3e2f44ab025434) Apply teletext page detection fix from fix branch - [`ebe25af`](https://github.com/CCExtractor/ccextractor/commit/ebe25af476c3a5452bc169793bdaefd2c6c9775e) Fix indentation to use tabs consistently - [`17a8e1e`](https://github.com/CCExtractor/ccextractor/commit/17a8e1ec7b5410e6b8d19e0d953705d54215d29a) Remove unintended Cargo.lock changes - [`f30f276`](https://github.com/CCExtractor/ccextractor/commit/f30f276456331e9c05afc0c267f3c15f95da91d5) Apply code style fixes from clang-format - [`d524a02`](https://github.com/CCExtractor/ccextractor/commit/d524a0247fa88a8ce7e87abd9f435046d1febbd5) Merge pull request #2 from Rahul-2k4/copilot/fix-teletext-page-detection-issue-1034 ### 📊 Changes **2 files changed** (+40 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_encoders_common.c` (+22 -0) 📝 `src/lib_ccx/general_loop.c` (+18 -6) </details> ### 📄 Description This PR fixes Issue #1034, where running CCExtractor with -out=report does not list Teletext pages that contain possible subtitles, even though the same pages are correctly detected during normal extraction. In report-only mode, CCExtractor skips Teletext PES packet processing because the encoder context (enc_ctx) is not created. Since subtitle-page detection happens inside Teletext packet parsing, no pages are recorded in seen_sub_page[], resulting in an empty Pages With Subtitles: field in the final report. This PR enables Teletext detection in -out=report mode and ensures proper memory cleanup when the encoder is absent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:33 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2516