[PR #1032] [MERGED] [IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker!

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1032 **Author:** [@MatejMecka](https://github.com/MatejMecka) **Created:** 10/31/2018 **Status:** ✅ Merged **Merged:** 11/2/2018 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/finalMarker` --- ### 📝 Commits (8) - [`a99cf6e`](https://github.com/CCExtractor/ccextractor/commit/a99cf6e7e3d67792ab8f760f1319a24304e46840) Merge pull request #1 from CCExtractor/master - [`9fa77f6`](https://github.com/CCExtractor/ccextractor/commit/9fa77f6cb9535056cb0b5e53be8efc8fc81f9243) Merge branch 'master' of https://github.com/ccextractor/ccextractor - [`733bd31`](https://github.com/CCExtractor/ccextractor/commit/733bd31f2a2e23582454c626afd1dcec1d8502fb) Less Harsher when Marker is missing - [`6893419`](https://github.com/CCExtractor/ccextractor/commit/6893419e0ff8f4ab2ea0980b1ea604200c05dafb) Update changelog - [`6329cdd`](https://github.com/CCExtractor/ccextractor/commit/6329cdd8b402fb8ee8b08c87e21e138b8ed14eb2) Skip Block by breaking - [`3107387`](https://github.com/CCExtractor/ccextractor/commit/310738740bbce4c8431964474cc0634f2fbb0fdb) Reference GitHub issue - [`c484898`](https://github.com/CCExtractor/ccextractor/commit/c4848980c7cb10d3b6181010ae7302f78a802693) Forgot {} - [`ec791a7`](https://github.com/CCExtractor/ccextractor/commit/ec791a743ee3fc2c2c74d2975dfa9b6429d9be89) Update docs/CHANGES.TXT ### 📊 Changes **2 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/avc_functions.c` (+5 -4) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- The User reported issues with Extracting the file due to fatals! Instead of Crashing with @cfsmp3 decided to warn since those things can happen due to a bad stream! Replaced the fatal with mprint --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:18:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1032
Author: @MatejMecka
Created: 10/31/2018
Status: ✅ Merged
Merged: 11/2/2018
Merged by: @cfsmp3

Base: master ← Head: fix/finalMarker

📝 Commits (8)

a99cf6e Merge pull request #1 from CCExtractor/master
9fa77f6 Merge branch 'master' of https://github.com/ccextractor/ccextractor
733bd31 Less Harsher when Marker is missing
6893419 Update changelog
6329cdd Skip Block by breaking
3107387 Reference GitHub issue
c484898 Forgot {}
ec791a7 Update docs/CHANGES.TXT

📊 Changes

2 files changed (+6 additions, -4 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/avc_functions.c (+5 -4)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

The User reported issues with Extracting the file due to fatals! Instead of Crashing with @cfsmp3 decided to warn since those things can happen due to a bad stream! Replaced the fatal with mprint

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:18:46 +00:00

claunia referenced this issue

2026-01-29 17:22:58 +00:00

[PR #1832] [CLOSED] [FIX] Prevent creation of empty per-stream subtitle files #2587

[PR #1832] [FIX] Prevent creation of empty per-stream subtitle files #2591

[PR #1032] [MERGED] [IMPROVEMENT] Warn instead of Crash for Missing Final 0xFF Marker! #1832

📋 Pull Request Information

📝 Commits (8)

📊 Changes

📄 Description