[PR #1832] [FIX] Prevent creation of empty per-stream subtitle files #2591

Open
opened 2026-01-29 17:22:58 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1832

State: closed
Merged: No


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

[FIX] Prevent creation of empty per-stream subtitle files (Fixes #1282)

This pull request implements deferred output file creation to avoid producing zero-byte .srt files for caption streams that contain no actual data.

  • Track per-output writes via wrote_data on ccx_s_write.
  • When no data is written to an output, skip footer writing and delete the file on teardown to avoid empty cc3 artifacts.
**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1832 **State:** closed **Merged:** No --- <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [X] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- ## **[FIX] Prevent creation of empty per-stream subtitle files (Fixes #1282)** #### This pull request implements deferred output file creation to avoid producing zero-byte `.srt` files for caption streams that contain no actual data. - Track per-output writes via wrote_data on ccx_s_write. - When no data is written to an output, skip footer writing and delete the file on teardown to avoid empty cc3 artifacts.
claunia added the pull-request label 2026-01-29 17:22:58 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2591