[PR #1142] [MERGED] [FIX] Segmentation fault on VOB #1128

claunia commented

2026-01-29 17:19:16 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1142
Author: @Sudoxo
Created: 12/9/2019
Status: ✅ Merged
Merged: 12/10/2019
Merged by: @cfsmp3

Base: master ← Head: PK

📝 Commits (1)

c9e8c86 [FIX] Segmentation fault on VOB #1128

📊 Changes

4 files changed (+24 additions, -1 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_decoders_common.c (+1 -0)
📝 src/lib_ccx/dvd_subtitle_decoder.c (+15 -1)
📝 src/lib_ccx/ocr.c (+7 -0)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Issue #1128
Changes:

checking if pointer isn't NULL in get_bitmap in file dvd_subtitle_decoder.c
checking in 3 places if the height or width isn't negative value
setting default value of ctx->is_alloc
checking if ctx->pos > ctx->len in decode_packet in dvd_subtitle_decoder.c
changed changes.TXT

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1142 **Author:** [@Sudoxo](https://github.com/Sudoxo) **Created:** 12/9/2019 **Status:** ✅ Merged **Merged:** 12/10/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `PK` --- ### 📝 Commits (1) - [`c9e8c86`](https://github.com/CCExtractor/ccextractor/commit/c9e8c866853132500edd5ecc8837459b48d31dce) [FIX] Segmentation fault on VOB #1128 ### 📊 Changes **4 files changed** (+24 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_decoders_common.c` (+1 -0) 📝 `src/lib_ccx/dvd_subtitle_decoder.c` (+15 -1) 📝 `src/lib_ccx/ocr.c` (+7 -0) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Issue #1128 Changes: - checking if pointer isn't NULL in get_bitmap in file dvd_subtitle_decoder.c - checking in 3 places if the height or width isn't negative value - setting default value of ctx->is_alloc - checking if ctx->pos > ctx->len in decode_packet in dvd_subtitle_decoder.c - changed changes.TXT --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>