[PR #1922] [FIX]: utf8proc include path for system library builds

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1922 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that another pull request for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. - [X] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [X] I am an active contributor to CCExtractor. --- ## Problem CCExtractor uses a non-standard include path for `utf8proc` in `src/lib_ccx/params.c`: - `#include <utf8proc/utf8proc.h>` However, utf8proc is installed as `<utf8proc.h>` (without a subdirectory) on all major platforms: - **Debian/Ubuntu**: `/usr/include/utf8proc.h` - **Fedora/RHEL**: `/usr/include/utf8proc.h` - **Homebrew**: `$(brew --prefix)/include/utf8proc.h` - **Nix**: `$out/include/utf8proc.h` - **vcpkg**: `installed/<triplet>/include/utf8proc.h` This caused build failures when using the `-system-libs` flag on Homebrew Linux. ## Solution This PR uses `__has_include()` to support both paths: - **System builds**: Uses `<utf8proc.h>` (standard location) - **Vendored builds**: Uses `<utf8proc/utf8proc.h>` (CCExtractor's vendored copy) Also removes the temporary symlink workaround from `linux/build` as it's no longer needed. ## Testing - Builds with `-system-libs` and without on Linux - Docker builds work (vendored) - macOS builds pass - windows build pass

claunia commented

2026-01-29 17:23:35 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1922

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Problem

CCExtractor uses a non-standard include path for utf8proc in src/lib_ccx/params.c:

#include <utf8proc/utf8proc.h>

However, utf8proc is installed as <utf8proc.h> (without a subdirectory) on all major platforms:

Debian/Ubuntu: /usr/include/utf8proc.h
Fedora/RHEL: /usr/include/utf8proc.h
Homebrew: $(brew --prefix)/include/utf8proc.h
Nix: $out/include/utf8proc.h
vcpkg: installed/<triplet>/include/utf8proc.h

This caused build failures when using the -system-libs flag on Homebrew Linux.

Solution

This PR uses __has_include() to support both paths:

System builds: Uses <utf8proc.h> (standard location)
Vendored builds: Uses <utf8proc/utf8proc.h> (CCExtractor's vendored copy)

Also removes the temporary symlink workaround from linux/build as it's no longer needed.

Testing

Builds with -system-libs and without on Linux
Docker builds work (vendored)
macOS builds pass
windows build pass

claunia added the pull-request label 2026-01-29 17:23:35 +00:00

[PR #1922] [FIX]: utf8proc include path for system library builds #2721

Problem

Solution

Testing