[PR #1153] [IMPROVEMENT] Removed redundant check_configuration_file function

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1153 **State:** closed **Merged:** Yes --- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- The `check_configuration_file` function takes in a dereferenced `ccx_s_options` struct as `api_options`, and calls `parse_configuration` by taking a reference to `api_options` . However, the only call to `check_configuration_file` is made by dereferencing a `ccx_s_options` struct, meaning `parse_configuration` can be called directly. Hence, there is no use for `check_configuration_file`, meaning it can be safely deleted.

claunia commented

2026-01-29 17:19:22 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1153

State: closed
Merged: Yes

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

The check_configuration_file function takes in a dereferenced ccx_s_options struct as api_options, and calls parse_configuration by taking a reference to api_options . However, the only call to check_configuration_file is made by dereferencing a ccx_s_options struct, meaning parse_configuration can be called directly. Hence, there is no use for check_configuration_file, meaning it can be safely deleted.

claunia added the pull-request label 2026-01-29 17:19:22 +00:00

claunia referenced this issue

2026-01-29 17:23:41 +00:00

[PR #1940] [MERGED] fix(args): Add --sc alias for --sentencecap for backwards compatibility #2737

[PR #1153] [IMPROVEMENT] Removed redundant check_configuration_file function #1940