[PR #1940] [MERGED] fix(args): Add --sc alias for --sentencecap for backwards compatibility #2737

Closed
opened 2026-01-29 17:23:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1940
Author: @cfsmp3
Created: 12/31/2025
Status: Merged
Merged: 12/31/2025
Merged by: @cfsmp3

Base: masterHead: fix/sc-alias-backwards-compat


📝 Commits (1)

  • 718eb1a fix(args): Add --sc alias for --sentencecap for backwards compatibility

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/rust/src/args.rs (+1 -1)

📄 Description

Summary

Add --sc (and -sc) as an alias for --sentencecap for backwards compatibility.

The -sc flag was used in older versions (0.94 and earlier) for sentence capitalization. After the migration to the Rust argument parser, only --sentencecap was accepted.

This is the same pattern used for --svc--service in commit 64ce4ac8.

Changes

// Before
#[arg(long, verbatim_doc_comment, help_heading=OUTPUT_AFFECTING_OUTPUT_FILES)]
pub sentencecap: bool,

// After
#[arg(long, alias="sc", verbatim_doc_comment, help_heading=OUTPUT_AFFECTING_OUTPUT_FILES)]
pub sentencecap: bool,

Test plan

$ ./ccextractor --sc
Error: No input file specified  # ✓ Accepts the flag

$ ./ccextractor -sc  
Error: No input file specified  # ✓ Also works with single dash

Related to #1917

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1940 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 12/31/2025 **Status:** ✅ Merged **Merged:** 12/31/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/sc-alias-backwards-compat` --- ### 📝 Commits (1) - [`718eb1a`](https://github.com/CCExtractor/ccextractor/commit/718eb1a37fc4353f2fd7dd7e5b4c55cc0fba8e29) fix(args): Add --sc alias for --sentencecap for backwards compatibility ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/args.rs` (+1 -1) </details> ### 📄 Description ## Summary Add `--sc` (and `-sc`) as an alias for `--sentencecap` for backwards compatibility. The `-sc` flag was used in older versions (0.94 and earlier) for sentence capitalization. After the migration to the Rust argument parser, only `--sentencecap` was accepted. This is the same pattern used for `--svc` → `--service` in commit 64ce4ac8. ## Changes ```rust // Before #[arg(long, verbatim_doc_comment, help_heading=OUTPUT_AFFECTING_OUTPUT_FILES)] pub sentencecap: bool, // After #[arg(long, alias="sc", verbatim_doc_comment, help_heading=OUTPUT_AFFECTING_OUTPUT_FILES)] pub sentencecap: bool, ``` ## Test plan ```bash $ ./ccextractor --sc Error: No input file specified # ✓ Accepts the flag $ ./ccextractor -sc Error: No input file specified # ✓ Also works with single dash ``` Related to #1917 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:23:41 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2737