[PR #1155] [MERGED] [FIX] Initialize fatal_ftn before first use

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1155 **Author:** [@MarcusGaiusPompey](https://github.com/MarcusGaiusPompey) **Created:** 12/22/2019 **Status:** ✅ Merged **Merged:** 12/27/2019 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fatal_ftn_init` --- ### 📝 Commits (2) - [`da37316`](https://github.com/CCExtractor/ccextractor/commit/da37316971241645166f1c53596d82a6319dfcfa) Initialize fatal_ftn before first use - [`a88f59c`](https://github.com/CCExtractor/ccextractor/commit/a88f59c1f1ff7c2362dd9847a5ade0be952f3c72) Merge branch 'master' into fatal_ftn_init ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/lib_ccx.c` (+7 -7) </details> ### 📄 Description Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- In `init_libraries`, if the first call to `malloc` to initialise the `lib_ccx_ctx` struct fails, `fatal_ftn` is called. However, the first definition of `fatal_ftn` occurs if the call succeeds, meaning that `fatal_ftn` is undefined at the first possible call. By initialising the logging functions before any other code is run, meaning that `fatal_ftn` should always be defined when called. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:19:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1155
Author: @MarcusGaiusPompey
Created: 12/22/2019
Status: ✅ Merged
Merged: 12/27/2019
Merged by: @cfsmp3

Base: master ← Head: fatal_ftn_init

📝 Commits (2)

da37316 Initialize fatal_ftn before first use
a88f59c Merge branch 'master' into fatal_ftn_init

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/lib_ccx.c (+7 -7)

📄 Description

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

In init_libraries, if the first call to malloc to initialise the lib_ccx_ctx struct fails, fatal_ftn is called. However, the first definition of fatal_ftn occurs if the call succeeds, meaning that fatal_ftn is undefined at the first possible call.

By initialising the logging functions before any other code is run, meaning that fatal_ftn should always be defined when called.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}