[PR #1941] [RUST] Document EIA-708 buffer size and remove debug logging #2743

Open
opened 2026-01-29 17:23:42 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1941

State: closed
Merged: Yes


Summary

Addresses two TODO items in the Rust codebase:

  1. Document EIA_708_BUFFER_LENGTH: Added proper documentation explaining the buffer size choice
  2. Remove debug print: Removed unnecessary debug logging from target.rs

Changes

constants.rs (Line ~150)

  • Replaced TODO comment with detailed documentation
  • Explains that 2048 bytes is 16x the CEA-708 spec minimum (128 bytes)
  • Added reference to CEA-708-E Section 8.4.3

target.rs (Line ~85)

  • Removed debug logging of target address as requested by TODO

Research

According to CEA-708-E specification Section 8.4.3, the minimum Service Input Buffer size is 128 bytes. CCExtractor uses 2048 bytes (16x larger) to provide adequate safety margin for buffer management.

Testing

✅ Changes are documentation and debug cleanup only
✅ No functional/logic changes
✅ CI will verify build compatibility

Part of ongoing Rust codebase cleanup effort to resolve TODO items.


In raising this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project:

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.
**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1941 **State:** closed **Merged:** Yes --- ## Summary Addresses two TODO items in the Rust codebase: 1. **Document EIA_708_BUFFER_LENGTH**: Added proper documentation explaining the buffer size choice 2. **Remove debug print**: Removed unnecessary debug logging from target.rs ## Changes ### constants.rs (Line ~150) - Replaced TODO comment with detailed documentation - Explains that 2048 bytes is 16x the CEA-708 spec minimum (128 bytes) - Added reference to CEA-708-E Section 8.4.3 ### target.rs (Line ~85) - Removed debug logging of target address as requested by TODO ## Research According to CEA-708-E specification Section 8.4.3, the minimum Service Input Buffer size is 128 bytes. CCExtractor uses 2048 bytes (16x larger) to provide adequate safety margin for buffer management. ## Testing ✅ Changes are documentation and debug cleanup only ✅ No functional/logic changes ✅ CI will verify build compatibility ## Related Part of ongoing Rust codebase cleanup effort to resolve TODO items. --- **In raising this pull request, I confirm the following:** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT). **My familiarity with the project:** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor.
claunia added the pull-request label 2026-01-29 17:23:42 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2743