[PR #1209] [IMPROVEMENT] Write CRLF line endings in SCC files #2006

Closed
opened 2026-01-29 17:19:44 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1209

State: closed
Merged: Yes


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have used CCExtractor just a couple of times.

All the SCC and CCD examples I can find have CRLF line endings. VLC and libavformat (used by MPV) don't care, so just go with the popular convention and switch to CRLF. There's no reason a user would want to choose their line endings in this scenario.

This also adds 2 trailing new lines as is the convention for SCC/CCD files.

This addresses one of the items in #1191.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1209 **State:** closed **Merged:** Yes --- **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [x] I have used CCExtractor just a couple of times. --- All the SCC and CCD examples I can find have CRLF line endings. VLC and libavformat (used by MPV) don't care, so just go with the popular convention and switch to CRLF. There's no reason a user would want to choose their line endings in this scenario. This also adds 2 trailing new lines as is the convention for SCC/CCD files. This addresses one of the items in #1191.
claunia added the pull-request label 2026-01-29 17:19:44 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2006