[PR #2006] [MERGED] fix: Remove debug println that printed spurious numbers during processing #2807

Open
opened 2026-01-29 17:24:00 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2006
Author: @cfsmp3
Created: 1/10/2026
Status: Merged
Merged: 1/10/2026
Merged by: @cfsmp3

Base: masterHead: fix/remove-debug-println-in-timestamp


📝 Commits (1)

  • 4d71837 fix: Remove debug println that printed spurious numbers during processing

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 src/rust/lib_ccxr/src/time/units.rs (+0 -3)

📄 Description

Summary

  • Removes a debug println! statement in the Rust timestamp conversion code (src/rust/lib_ccxr/src/time/units.rs)
  • This debug code was printing the hours value when it exceeded 24, causing spurious numbers (like "25") to appear in the output

Problem

When processing files with PTS timestamps exceeding 24 hours (e.g., DVB teletext streams where the PCR/PTS base is set to 25+ hours), the debug statement would print just the hours value on its own line, polluting the output:

VBI/teletext stream ID 439 (0x1b7) for SID 16411 (0x401b)
25
25
  1%  |  265:45
25
...

Fix

Remove the leftover debug code:

// REMOVED:
if h > 24 {
    println!("{h}")
}

Test plan

  • Build succeeds
  • Tested with DVB teletext sample (dvbt.ts) - no more spurious numbers in output
  • Normal file processing unaffected

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2006 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/remove-debug-println-in-timestamp` --- ### 📝 Commits (1) - [`4d71837`](https://github.com/CCExtractor/ccextractor/commit/4d718378d599f8fc807fda2888b577bf5df841f1) fix: Remove debug println that printed spurious numbers during processing ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/lib_ccxr/src/time/units.rs` (+0 -3) </details> ### 📄 Description ## Summary - Removes a debug `println!` statement in the Rust timestamp conversion code (`src/rust/lib_ccxr/src/time/units.rs`) - This debug code was printing the hours value when it exceeded 24, causing spurious numbers (like "25") to appear in the output ## Problem When processing files with PTS timestamps exceeding 24 hours (e.g., DVB teletext streams where the PCR/PTS base is set to 25+ hours), the debug statement would print just the hours value on its own line, polluting the output: ``` VBI/teletext stream ID 439 (0x1b7) for SID 16411 (0x401b) 25 25 1% | 265:45 25 ... ``` ## Fix Remove the leftover debug code: ```rust // REMOVED: if h > 24 { println!("{h}") } ``` ## Test plan - [x] Build succeeds - [x] Tested with DVB teletext sample (`dvbt.ts`) - no more spurious numbers in output - [x] Normal file processing unaffected 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:24:00 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2807