[PR #1247] [MERGED] [IMPROVEMENT] Apply clang-format to all remaining files #2041

Closed
opened 2026-01-29 17:19:55 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1247
Author: @canihavesomecoffee
Created: 3/28/2020
Status: Merged
Merged: 3/29/2020
Merged by: @canihavesomecoffee

Base: masterHead: clang-tidy/part1


📝 Commits (5)

  • 27e6f02 apply clang-format to all GUI files except for the icons file
  • 9fd4868 Do not run on third party or the icons file
  • aa1f44a Apply clang-format to all lib_ccx files
  • 289e4f8 Apply clang-format to all wrappers files
  • 00740e8 Remove thirdparty as it's already covered by a clang-format rule file

📊 Changes

80 files changed (+4844 additions, -4686 deletions)

View changed files

📝 .github/workflows/format.yml (+1 -1)
📝 src/GUI/activity.c (+2 -2)
📝 src/GUI/ccextractorGUI.c (+195 -210)
📝 src/GUI/ccx_cli_thread.c (+73 -75)
📝 src/GUI/command_builder.c (+267 -245)
📝 src/GUI/file_browser.c (+177 -154)
📝 src/GUI/popups.c (+33 -32)
📝 src/GUI/preview.c (+2 -4)
📝 src/GUI/save_load_data.c (+63 -74)
📝 src/GUI/tabs.c (+174 -169)
📝 src/GUI/terminal.c (+1 -1)
📝 src/ccextractor.c (+38 -43)
📝 src/lib_ccx/activity.c (+4 -5)
📝 src/lib_ccx/asf_functions.c (+74 -91)
📝 src/lib_ccx/avc_functions.c (+53 -52)
📝 src/lib_ccx/cc_bitstream.c (+1 -15)
📝 src/lib_ccx/ccx_common_char_encoding.c (+12 -12)
📝 src/lib_ccx/ccx_common_common.c (+5 -4)
📝 src/lib_ccx/ccx_common_constants.c (+124 -133)
📝 src/lib_ccx/ccx_common_option.c (+41 -44)

...and 60 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Applies clang-format to all failing files:

  • GUI files
  • lib_ccx files
  • wrappers files

Excludes running checks on:

  • third party (src/thirdparty)
  • icons file of GUI

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1247 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 3/28/2020 **Status:** ✅ Merged **Merged:** 3/29/2020 **Merged by:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Base:** `master` ← **Head:** `clang-tidy/part1` --- ### 📝 Commits (5) - [`27e6f02`](https://github.com/CCExtractor/ccextractor/commit/27e6f0288549648c4d6af90b3cab44e45f560cf7) apply clang-format to all GUI files except for the icons file - [`9fd4868`](https://github.com/CCExtractor/ccextractor/commit/9fd48682a785b56d37dcbc0bf6feaf2f1609bf75) Do not run on third party or the icons file - [`aa1f44a`](https://github.com/CCExtractor/ccextractor/commit/aa1f44a4fd8748f8f554508cccc92ff85ee48058) Apply clang-format to all lib_ccx files - [`289e4f8`](https://github.com/CCExtractor/ccextractor/commit/289e4f8205535f89251ea65b221580f794632ab8) Apply clang-format to all wrappers files - [`00740e8`](https://github.com/CCExtractor/ccextractor/commit/00740e8dba70e27507206229e19d82be578fc1b6) Remove thirdparty as it's already covered by a clang-format rule file ### 📊 Changes **80 files changed** (+4844 additions, -4686 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/format.yml` (+1 -1) 📝 `src/GUI/activity.c` (+2 -2) 📝 `src/GUI/ccextractorGUI.c` (+195 -210) 📝 `src/GUI/ccx_cli_thread.c` (+73 -75) 📝 `src/GUI/command_builder.c` (+267 -245) 📝 `src/GUI/file_browser.c` (+177 -154) 📝 `src/GUI/popups.c` (+33 -32) 📝 `src/GUI/preview.c` (+2 -4) 📝 `src/GUI/save_load_data.c` (+63 -74) 📝 `src/GUI/tabs.c` (+174 -169) 📝 `src/GUI/terminal.c` (+1 -1) 📝 `src/ccextractor.c` (+38 -43) 📝 `src/lib_ccx/activity.c` (+4 -5) 📝 `src/lib_ccx/asf_functions.c` (+74 -91) 📝 `src/lib_ccx/avc_functions.c` (+53 -52) 📝 `src/lib_ccx/cc_bitstream.c` (+1 -15) 📝 `src/lib_ccx/ccx_common_char_encoding.c` (+12 -12) 📝 `src/lib_ccx/ccx_common_common.c` (+5 -4) 📝 `src/lib_ccx/ccx_common_constants.c` (+124 -133) 📝 `src/lib_ccx/ccx_common_option.c` (+41 -44) _...and 60 more files_ </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Applies clang-format to all failing files: - GUI files - lib_ccx files - wrappers files Excludes running checks on: - third party (src/thirdparty) - icons file of GUI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:19:55 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2041