[PR #2041] [MERGED] refactor(rust): Rename parser tests with descriptive names and expand coverage #2847

New Issue

claunia · 2026-01-29T17:24:13Z

claunia commented

2026-01-29 17:24:13 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2041
Author: @cfsmp3
Created: 1/18/2026
Status: ✅ Merged
Merged: 1/19/2026
Merged by: @cfsmp3

Base: master ← Head: refactor/parser-test-names

📝 Commits (1)

735a01b refactor(rust): rename parser tests with descriptive names and expand coverage

📊 Changes

1 file changed (+1204 additions, -441 deletions)

View changed files

📝 src/rust/src/parser.rs (+1204 -441)

📄 Description

Summary

Replace poorly-named tests (options_1 through options_51, broken_1, etc.) with 201 descriptively-named tests
Organize tests by category (input formats, output formats, encoding, timing, debug flags, etc.)
Each test name now clearly indicates what CLI option is being tested and expected behavior

Examples of renamed tests

Before	After
`options_1`	`test_input_ts_sets_transport_stream_mode`
`options_27`	`test_debug_enables_verbose_debug`
`options_28`	`test_608_enables_decoder_608_debug`
`broken_1`	`test_autoprogram_with_srt_and_latin1`

Test plan

cargo fmt passes
cargo clippy passes
cargo test passes (all 395 tests)

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2041 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 1/18/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `refactor/parser-test-names` --- ### 📝 Commits (1) - [`735a01b`](https://github.com/CCExtractor/ccextractor/commit/735a01bf045b5e1097f6e0d9c7dbfa7db5f91882) refactor(rust): rename parser tests with descriptive names and expand coverage ### 📊 Changes **1 file changed** (+1204 additions, -441 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/parser.rs` (+1204 -441) </details> ### 📄 Description ## Summary - Replace poorly-named tests (`options_1` through `options_51`, `broken_1`, etc.) with 201 descriptively-named tests - Organize tests by category (input formats, output formats, encoding, timing, debug flags, etc.) - Each test name now clearly indicates what CLI option is being tested and expected behavior ## Examples of renamed tests | Before | After | |--------|-------| | `options_1` | `test_input_ts_sets_transport_stream_mode` | | `options_27` | `test_debug_enables_verbose_debug` | | `options_28` | `test_608_enables_decoder_608_debug` | | `broken_1` | `test_autoprogram_with_srt_and_latin1` | ## Test categories (201 total) - Input formats (12 tests) - Output formats (19 tests) - Encoding (7 tests) - Stream/program selection (10 tests) - CEA-708 services (7 tests) - Codec selection (4 tests) - Timing options (12 tests) - Debug flags (17 tests) - Teletext options (8 tests) - Credits options (8 tests) - And more... ## Test plan - [x] `cargo fmt` passes - [x] `cargo clippy` passes - [x] `cargo test` passes (all 395 tests) 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:24:13 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2847