mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
[PR #1553] [CLOSED] [FEAT] Add log module in lib_ccxr
#2268
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/CCExtractor/ccextractor/pull/1553
Author: @elbertronnie
Created: 8/27/2023
Status: ❌ Closed
Base:
master← Head:add-log-module📝 Commits (3)
8014d8bcreate lib_ccxr and libccxr_exports8f348feadd log module16f7aaeused expect and remove need for global ccx_options📊 Changes
12 files changed (+740 additions, -62 deletions)
View changed files
📝
.gitignore(+2 -1)📝
src/lib_ccx/lib_ccx.c(+8 -0)📝
src/rust/Cargo.lock(+98 -61)📝
src/rust/Cargo.toml(+1 -0)📝
src/rust/build.rs(+1 -0)➕
src/rust/lib_ccxr/Cargo.lock(+16 -0)➕
src/rust/lib_ccxr/Cargo.toml(+18 -0)➕
src/rust/lib_ccxr/src/lib.rs(+1 -0)➕
src/rust/lib_ccxr/src/util/log.rs(+546 -0)➕
src/rust/lib_ccxr/src/util/mod.rs(+3 -0)📝
src/rust/src/lib.rs(+1 -0)➕
src/rust/src/libccxr_exports/mod.rs(+45 -0)📄 Description
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
This is an attempt to split #1495 into multiple independant PRs. Dependant on #1551.
This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included.
NOTE: I have not used the famous log crate due to the huge differences in how CCExtractor's logging works compared to the log crate. But I have tried to keep the API as close as possible to the log crate.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.