[PR #1553] [CLOSED] [FEAT] Add log module in lib_ccxr #2268

Open
opened 2026-01-29 17:21:14 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1553
Author: @elbertronnie
Created: 8/27/2023
Status: Closed

Base: masterHead: add-log-module


📝 Commits (3)

  • 8014d8b create lib_ccxr and libccxr_exports
  • 8f348fe add log module
  • 16f7aae used expect and remove need for global ccx_options

📊 Changes

12 files changed (+740 additions, -62 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 src/lib_ccx/lib_ccx.c (+8 -0)
📝 src/rust/Cargo.lock (+98 -61)
📝 src/rust/Cargo.toml (+1 -0)
📝 src/rust/build.rs (+1 -0)
src/rust/lib_ccxr/Cargo.lock (+16 -0)
src/rust/lib_ccxr/Cargo.toml (+18 -0)
src/rust/lib_ccxr/src/lib.rs (+1 -0)
src/rust/lib_ccxr/src/util/log.rs (+546 -0)
src/rust/lib_ccxr/src/util/mod.rs (+3 -0)
📝 src/rust/src/lib.rs (+1 -0)
src/rust/src/libccxr_exports/mod.rs (+45 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This is an attempt to split #1495 into multiple independant PRs. Dependant on #1551.

This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included.

NOTE: I have not used the famous log crate due to the huge differences in how CCExtractor's logging works compared to the log crate. But I have tried to keep the API as close as possible to the log crate.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1553 **Author:** [@elbertronnie](https://github.com/elbertronnie) **Created:** 8/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-log-module` --- ### 📝 Commits (3) - [`8014d8b`](https://github.com/CCExtractor/ccextractor/commit/8014d8b0c0938d1ad76911aa8c7256d81fcf7496) create lib_ccxr and libccxr_exports - [`8f348fe`](https://github.com/CCExtractor/ccextractor/commit/8f348fe2d9dc0ca382542e5d5ec6537b8a995116) add log module - [`16f7aae`](https://github.com/CCExtractor/ccextractor/commit/16f7aae78fd7974b782be878d1b35ceb464ec6a2) used expect and remove need for global ccx_options ### 📊 Changes **12 files changed** (+740 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `src/lib_ccx/lib_ccx.c` (+8 -0) 📝 `src/rust/Cargo.lock` (+98 -61) 📝 `src/rust/Cargo.toml` (+1 -0) 📝 `src/rust/build.rs` (+1 -0) ➕ `src/rust/lib_ccxr/Cargo.lock` (+16 -0) ➕ `src/rust/lib_ccxr/Cargo.toml` (+18 -0) ➕ `src/rust/lib_ccxr/src/lib.rs` (+1 -0) ➕ `src/rust/lib_ccxr/src/util/log.rs` (+546 -0) ➕ `src/rust/lib_ccxr/src/util/mod.rs` (+3 -0) 📝 `src/rust/src/lib.rs` (+1 -0) ➕ `src/rust/src/libccxr_exports/mod.rs` (+45 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This is an attempt to split #1495 into multiple independant PRs. Dependant on #1551. This PR adds functions and macros used for logging operations. The functions of this PR have not been integrated into the C codebase since there is no safe or easy way to pass variable number of arguments (as used in printf) from C to Rust. But the code for initializing the logger from C to Rust is included. NOTE: I have not used the famous log crate due to the huge differences in how CCExtractor's logging works compared to the log crate. But I have tried to keep the API as close as possible to the log crate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:14 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2268