mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/CCExtractor/ccextractor/pull/729
Author: @LucasYoung
Created: 3/30/2017
Status: ✅ Merged
Merged: 3/31/2017
Merged by: @cfsmp3
Base:
master← Head:master📝 Commits (2)
dd5c1eeAdded WebVTT output from Matroska5ffa442Removed changes to ccextractor.vcxproj📊 Changes
3 files changed (+139 additions, -2 deletions)
View changed files
📝
src/lib_ccx/matroska.c(+117 -2)📝
src/lib_ccx/matroska.h(+13 -0)📝
src/lib_ccx/utility.c(+9 -0)📄 Description
In raising this pull request, I confirm the following:
My familiarity with the project is as follows:
This pull request implements extraction of WebVTT subtitles from Matroska files. I am hoping to earn 5 GSOC qualification points from this pull request.
I have tested this code with the sample video in issue #724 and the output appears to be correct. However, I have not been able to find other applicable test cases for this code (mkv files with WebVTT subtitles). Also, all of my testing was done on a 64-bit Windows machine.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.