[PR #1556] [CLOSED] [FEAT] Add time units module in `lib_ccxr`

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1556 **Author:** [@elbertronnie](https://github.com/elbertronnie) **Created:** 8/27/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-time-units-module` --- ### 📝 Commits (3) - [`8014d8b`](https://github.com/CCExtractor/ccextractor/commit/8014d8b0c0938d1ad76911aa8c7256d81fcf7496) create lib_ccxr and libccxr_exports - [`49cdd1f`](https://github.com/CCExtractor/ccextractor/commit/49cdd1fd917f86ac59027139a8ad53eb8559bcc8) add time units module - [`b479f49`](https://github.com/CCExtractor/ccextractor/commit/b479f494820d0f1a1bd39fcc81be086751ad1315) use expect and re-use MPEG_CLOCK_FREQ from C ### 📊 Changes **15 files changed** (+1222 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) 📝 `src/lib_ccx/utility.c` (+33 -0) 📝 `src/rust/Cargo.lock` (+165 -58) 📝 `src/rust/Cargo.toml` (+1 -0) 📝 `src/rust/build.rs` (+7 -1) ➕ `src/rust/lib_ccxr/Cargo.lock` (+172 -0) ➕ `src/rust/lib_ccxr/Cargo.toml` (+20 -0) ➕ `src/rust/lib_ccxr/src/lib.rs` (+1 -0) ➕ `src/rust/lib_ccxr/src/util/mod.rs` (+3 -0) ➕ `src/rust/lib_ccxr/src/util/time/c_functions.rs` (+35 -0) ➕ `src/rust/lib_ccxr/src/util/time/mod.rs` (+27 -0) ➕ `src/rust/lib_ccxr/src/util/time/units.rs` (+641 -0) 📝 `src/rust/src/lib.rs` (+1 -0) ➕ `src/rust/src/libccxr_exports/mod.rs` (+5 -0) ➕ `src/rust/src/libccxr_exports/time.rs` (+109 -0) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This is an attempt to split #1495 into multiple independant PRs. Dependant on #1551. This PR adds types that enables to store time in different representations like simple milliseconds, number of frames, etc. And also allow to interconvert between them. It also provides functions for formatting time in different kinds of formats. Certain functions are integrated into C codebase. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:21:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1556
Author: @elbertronnie
Created: 8/27/2023
Status: ❌ Closed

Base: master ← Head: add-time-units-module

📝 Commits (3)

8014d8b create lib_ccxr and libccxr_exports
49cdd1f add time units module
b479f49 use expect and re-use MPEG_CLOCK_FREQ from C

📊 Changes

15 files changed (+1222 additions, -60 deletions)

View changed files

📝 .gitignore (+2 -1)
📝 src/lib_ccx/utility.c (+33 -0)
📝 src/rust/Cargo.lock (+165 -58)
📝 src/rust/Cargo.toml (+1 -0)
📝 src/rust/build.rs (+7 -1)
➕ src/rust/lib_ccxr/Cargo.lock (+172 -0)
➕ src/rust/lib_ccxr/Cargo.toml (+20 -0)
➕ src/rust/lib_ccxr/src/lib.rs (+1 -0)
➕ src/rust/lib_ccxr/src/util/mod.rs (+3 -0)
➕ src/rust/lib_ccxr/src/util/time/c_functions.rs (+35 -0)
➕ src/rust/lib_ccxr/src/util/time/mod.rs (+27 -0)
➕ src/rust/lib_ccxr/src/util/time/units.rs (+641 -0)
📝 src/rust/src/lib.rs (+1 -0)
➕ src/rust/src/libccxr_exports/mod.rs (+5 -0)
➕ src/rust/src/libccxr_exports/time.rs (+109 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This is an attempt to split #1495 into multiple independant PRs. Dependant on #1551.

This PR adds types that enables to store time in different representations like simple milliseconds, number of frames, etc. And also allow to interconvert between them. It also provides functions for formatting time in different kinds of formats. Certain functions are integrated into C codebase.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:21:15 +00:00

claunia closed this issue

2026-01-29 17:21:16 +00:00

[PR #1556] [CLOSED] [FEAT] Add time units module in lib_ccxr #2274

📋 Pull Request Information

📝 Commits (3)

📊 Changes

📄 Description

[PR #1556] [CLOSED] [FEAT] Add time units module in `lib_ccxr` #2274